Test every weapon and vehicle call

[ejdaduya]

No description provided.

[Girbons]

Hi @ejdaduya I really appreciate your pull request but as i suggested here i'd like to have explicit tests.
Could you please follow the suggested code?
Thanks very much for your help.

[ejdaduya]

Hi, as stated in line 86 & line 102, would you like to maybe add them to a log file or execute a specific task?

I've included a parameter as well in case you'd explicitly like to invoke the function.

I could make the explicit tests for you, but I thought you'd appreciate a dynamic function.

I'm pretty new here so please bear with me.

[Girbons]

@ejdaduya The submitted code is good but we have to make some changes, remove this
and the vehicles and weapons list

In the dynamic function I thought to do something like this:
Using the resolve weapon that you can find here

def weapon_call(weapon):
    bf = Battlefield('girbons', API_KEY, 'Pc')
    response = bf.progression_service.get_weapon(weapon=resolve_weapon(weapon))
    return response

Now you can use the dynamic function

def test_selbstlader_optical():
    response = weapon_call('selbstlader m1916 optical')
    assert response.status_code == 200

We can isolate tests for vehicles and weapons in 2 files

If you have another idea i'm glad to discuss it :)

[ejdaduya]

Should we discard the test_resolver.py and create a test_weapon_resolver.py and test_vehicle_resolver.py then?

[Girbons]

@ejdaduya yes

[Girbons]

@ejdaduya nice work, change the last thing and add your name to the contributors file and i will be happy to merge your pull request

[Girbons]

change it in lower case test_lawrence_of_arabias_smle

[ejdaduya]

Hi @Girbons, I've dropped some of the special characters for the function names. Kindly confirm if these meets your expectation.

[ejdaduya]

Hi @Girbons, that's probably all from me for today.

[Girbons]

@ejdaduya I will take a look in this afternoon it seems good,
Could you please check with an api_key if the tests are passing?
I don't know why the CI is not using the API_KEY and now I can't check the issue on travis

[ejdaduya]

Sure thing. I'll give you a feedback once I have some free time tonight.

[ejdaduya]

Hi @Girbons, I've tried running the tests and the resolver function does not seem to be applicable for the test functions.

Here are my current issues:

• resolve_weapon and resolve_vehicle returns the key value from the config file.
• bf.progression_service.get_vehicle and bf.progression_service.get_weapon returns a dictionary object, not a requests response, thus assert response.status_code == 200 would fail as well.

I've tested this by running pytest tests/test_vehicle_resolver.py and pytest tests/test_weapon_resolver.py and simply providing my API_KEY from the utils file.

[Girbons]

@ejdaduya I missed a step, my bad

[Girbons]

Thank you very much @ejdaduya :)

[ejdaduya]

Cheers!