Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine devcontainer configuration with gradle #172

Closed
wants to merge 11 commits into from

Conversation

alexcombessie
Copy link
Member

@alexcombessie alexcombessie commented Jul 25, 2022

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@alexcombessie alexcombessie marked this pull request as draft July 25, 2022 10:52
@alexcombessie alexcombessie self-assigned this Jul 25, 2022
@andreybavt
Copy link
Member

@alexcombessie , I checked, with the latest fix everything does work without CORS issues

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexcombessie
Copy link
Member Author

After epic struggles which master @andreybavt kenobi, we have decided not to pursue this pull request.

@andreybavt managed to make it work, but it requires the user to make port 9000 of the github codespace public. It is a manual action which is not great for security purposes.
image (8)

In addition to this, we are not fully convinced that github codespace is the best way to onboard new internal and external developers. It implies an important server cost, and the setup is quite involved.

Let's close this PR and focus on documenting the local dev setup on VScode for now.

@Hartorn Hartorn deleted the task/proper-dev-container branch March 7, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants