Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview always has a teal color even when it's not selected #610 #621

Merged
merged 5 commits into from Jan 1, 2023

Conversation

p4puniya
Copy link
Contributor

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

Copy link
Contributor

@Googleton Googleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are on the right track with the route path change, I'm not sure why changes were made to ProjectOverview.vue however

frontend/src/router.ts Outdated Show resolved Hide resolved
frontend/src/views/main/project/ProjectOverview.vue Outdated Show resolved Hide resolved
frontend/src/views/main/project/ProjectOverview.vue Outdated Show resolved Hide resolved
@p4puniya
Copy link
Contributor Author

Seems like my recent push went as a new Pull Request. Please check it out.

@andreybavt
Copy link
Member

hi @p4puniya , could you try pushing the latest modification to the changeOverviewColor branch so that it appears in this PR?

@andreybavt
Copy link
Member

andreybavt commented Dec 30, 2022

👇 failing build due to Sonar issue is a known problem for external contributors, I'll fix it soon

@p4puniya
Copy link
Contributor Author

p4puniya commented Dec 30, 2022

Done, but it's not failing this time

@Googleton Googleton self-requested a review December 30, 2022 19:18
Copy link
Contributor

@Googleton Googleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, looks good to me after your changes! @andreybavt I'll let you confirm and merge if it's fine for you

@andreybavt andreybavt merged commit 17ebf74 into Giskard-AI:main Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants