This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
49_popupsize #60
Merged
49_popupsize #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not fix popup positioning issues. Todo: fix issues with autopan.
|
I am afraid I don't have time to solve the autopan issue just yet. I created an issue #62 for that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make popups smaller on mobile by decreasing font size. Also adjust popup position to overlap clicked point.
Issues remain with OL autopan not working correctly. Intended behaviour is to pan the map when a popup opens so it fits on screen. Currently the map is only panned after the second click on the feature and even that is not done reliably.
The
position: absolutechange on mobile displays in this PR probably also prevents autopanning from working, but it does not work even if not manually setting position.@Joonalai if you have time you can take a look if you can solve issues with autopan, otherwise we can merge this and move popup positioning to a new issue.
Resolves #49.