Overhaul config parsing, custom viewmodel offsets #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for working on this project! It's really nice to see Portal 2 from a different perspective. Can't wait until proper 6DOF and roomscale features are implemented. Feel free to look at or steal my implementation in QuakeVR: where the magic happens and a general search for "roomscale".
This PR introduces two changes:
It overhauls the config parsing logic -- now every field can be optional, and comes with an hardcoded default that is loaded if the field is missing or if a parsing failure occurs. Error messages have also been improved.
Adds two new config entries:
ViewmodelPosCustomOffset[XYZ]
andViewmodelAngCustomOffset[XYZ]
. These are custom offsets applied on top of the hardcoded ones, allowing players to tweak the position and orientation of the viewmodel. With my Quest Pro controllers, for example, a value ofViewmodelPosCustomOffsetX=5
is desirable.