Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul config parsing, custom viewmodel offsets #23

Merged

Conversation

vittorioromeo
Copy link

First of all, thanks for working on this project! It's really nice to see Portal 2 from a different perspective. Can't wait until proper 6DOF and roomscale features are implemented. Feel free to look at or steal my implementation in QuakeVR: where the magic happens and a general search for "roomscale".

This PR introduces two changes:

  1. It overhauls the config parsing logic -- now every field can be optional, and comes with an hardcoded default that is loaded if the field is missing or if a parsing failure occurs. Error messages have also been improved.

  2. Adds two new config entries: ViewmodelPosCustomOffset[XYZ] and ViewmodelAngCustomOffset[XYZ]. These are custom offsets applied on top of the hardcoded ones, allowing players to tweak the position and orientation of the viewmodel. With my Quest Pro controllers, for example, a value of ViewmodelPosCustomOffsetX=5 is desirable.

@Gistix Gistix merged commit 7a20142 into Gistix:main Sep 18, 2023
@Gistix
Copy link
Owner

Gistix commented Sep 18, 2023

Thank you for your contribution!

@iburakov
Copy link

Here are the values I've settled on with Quest 2 controllers:

ViewmodelPosCustomOffsetX=7.0
ViewmodelPosCustomOffsetY=0.0
ViewmodelPosCustomOffsetZ=1.5

Maybe it'll save someone a minute.

Thanks for this experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants