Match Git config in a mixed-sensitively way #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git configuration entry keys are neither case sensitive, nor in-sensitive. They are mixed sensitive. The section and property names are NOT sensitive, but the 'scope' or inner component of the full name IS sensitive. For example, `credential.example.com.provider` is the same as `CREDENTIAL.example.com.PROVIDER`, but `credential.EXAMPLE.COM.provider` is NOT. We introduce a new StringComparer type that performs insensitive comparison on the section and property components, and sensitive comparison on the scope component.
src/shared/Microsoft.Git.CredentialManager/GitConfigurationKeyComparer.cs
Show resolved
Hide resolved
jeffhostetler
approved these changes
Nov 25, 2020
Add more tests to the GitConfigurationKeyComparer tests, specifically around cases that contain no period/dots '.'. In these cases we behave as StringComparer.Ordinal.
This was referenced Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git configuration entry keys are neither case sensitive, nor in-sensitive. They are mixed sensitive.
The section and property names are NOT sensitive, but the 'scope' or inner component of the full name IS sensitive.
For example,
credential.example.com.provideris the same asCREDENTIAL.example.com.PROVIDER, butcredential.EXAMPLE.COM.provideris NOT.We introduce a new StringComparer type that performs insensitive comparison on the section and property components, and sensitive comparison on the scope component.
Fixes #223