Integrate with the shared Microsoft developer tools AAD token cache on macOS #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
added
enhancement
mjcheetham
force-pushed
the
msalcache-osx
branch
from
79cbf90
to
d60b8e0
Compare
bgavrilMS
reviewed
Feb 2, 2021
src/shared/Microsoft.Git.CredentialManager/Authentication/MicrosoftAuthentication.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 2, 2021
src/shared/Microsoft.Git.CredentialManager/Authentication/MicrosoftAuthentication.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Feb 2, 2021
mjcheetham
force-pushed
the
msalcache-osx
branch
2 times, most recently
from
362b6fd
to
42b814e
Compare
bgavrilMS
approved these changes
Feb 2, 2021
derrickstolee
approved these changes
Feb 2, 2021
Full the ~/.gcm data directory path calculation to a property of the IFileSystem component.
Integrate with the shared Microsoft developer tools cache on macOS platforms. This allows us to share refresh tokens with VSMac and Azure CLI.
mjcheetham
force-pushed
the
msalcache-osx
branch
from
42b814e
to
10c83a1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various Microsoft developer tools share a token cache used by the MSAL library on macOS. This includes Visual Studio for Mac, and Azure CLI amongst others. This allows us to share refresh tokens those applications.