Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntegrationTests\UpdateVerb #193

Open
wants to merge 6 commits into
base: release/v0.5.0
Choose a base branch
from

Conversation

powellm123
Copy link

Adding Integration test that tests the Update Verb

@pdubb29
Copy link
Contributor

pdubb29 commented Mar 20, 2017

Build Failure :(

@powellm123
Copy link
Author

How do you rerun the tests?

@kjjuno
Copy link
Member

kjjuno commented Mar 21, 2017

@powellm123 I believe you just have to push new code. There may be a way to go the appveyor page and tell it to re-run a build. But I'm not sure.

@kjjuno kjjuno changed the base branch from develop to release/v0.5.0 March 22, 2017 23:12
Adding some logging to see if we can figure out why this fails on AppVeyor.

namespace Lib1
{
public class StringUtils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this indentation change intentional? If this is the change, I would prefer something else. This kind of indentation stuff is a pet peeve.

@@ -30,21 +57,47 @@ public void InvalidVerb_Returns_InvalidCommand()
[Test]
public void CloneVerb_ShouldCloneAllRepos()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all in the HelpPageScenario, which should focus only on Help page work flows. You should create a new Scenario file for Cloning.

Assert.IsTrue(lib2Exists);

[Test]
public void UpdateVerb_CloneReposChangeLib1_ShouldUpdateArtifacts()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all in the HelpPageScenario, which should focus only on Help page work flows. You should create a new Scenario file for Updating.

@pdubb29 pdubb29 added this to the v0.5.0 milestone Mar 28, 2017
@kjjuno kjjuno removed this from the v0.5.0 milestone Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants