Turn IgnoredMatch into a dataclass

[agateau-gg]

IgnoredMatch is currently defined as a Dict[str, str] with two entries: name and match.

It should be turned into a dataclass to improve type-safety and make code more expressive. The Cache code must be updated as well, since it also uses the IgnoredMatch dict.

[karo-fox]

Can I help with this one?

[agateau-gg]

Can I help with this one?

Sure, you are more than welcome to work on this! It's better if you wait until #247 is merged though: turning IgnoredMatch into a dataclass is the continuation of the work started with the rework of the configuration file. It should be merged today hopefully 🤞🏻.

[karo-fox]

Can I start working on it now?

[agateau-gg]

Yes, you can 👍🏻

[karo-fox]

Should I create branch from main?

[agateau-gg]

No, it's better if you start from the iac branch: the main branch does not contain the new configuration code yet.

[karo-fox]

Should IgnoredMatch support loading from config file with list of secrets? Like this:

matches-ignore:
  - 530e5a4a7ea00814db8845dd0cae5efaa4b974a3ce1c76d0384ba715248a5dc1
  - MY_TEST_CREDENTIAL

[agateau-gg]

No, the v2 configuration file format only supports the syntax where a match is declared as an object with name and match keys. So this should be supported:

# correct
secret:
  ignored-matches:
  - name: some secret
    match: 530e5a4a7ea00814db8845dd0cae5efaa4b974a3ce1c76d0384ba715248a5dc1
  - name: another secret
    match: 559583106f3b760810fcb41d7cb99da6e7d118912cdeca19a57358c4b6a6a627

But this should not:

# incorrect
secret:
  ignored-matches:
  - 530e5a4a7ea00814db8845dd0cae5efaa4b974a3ce1c76d0384ba715248a5dc1
  - 559583106f3b760810fcb41d7cb99da6e7d118912cdeca19a57358c4b6a6a627