Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ggshield secret scan repo spams the terminal #265

Closed
agateau-gg opened this issue Jun 14, 2022 · 1 comment · Fixed by #288
Closed

ggshield secret scan repo spams the terminal #265

agateau-gg opened this issue Jun 14, 2022 · 1 comment · Fixed by #288
Labels
good first issue Good for newcomers regression A feature which used to work in the past does not work anymore, or a behavior changed status:confirmed This issue has been reviewed and confirmed type:bug Something isn't working
Milestone
1.13.0

Comments

@agateau-gg
Copy link
Collaborator

agateau-gg commented Jun 14, 2022 •
edited

GitGuardian Shield Version

  • v1.12.0

Describe the bug

When scanning a repository using ggshield secret scan repo, ggshield prints "No secrets have been found" for each scanned commit.

Expected behavior

ggshield should print "No secrets have been found" only once, at the end.
@agateau-gg agateau-gg added type:bug Something isn't working good first issue Good for newcomers status:confirmed This issue has been reviewed and confirmed labels Jun 14, 2022
@deimosfr
Copy link

Getting the same issue

@agateau-gg agateau-gg added this to the 1.12.1 milestone Jun 28, 2022
@agateau-gg agateau-gg added the regression A feature which used to work in the past does not work anymore, or a behavior changed label Jun 28, 2022
@Lotram Lotram mentioned this issue Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers regression A feature which used to work in the past does not work anymore, or a behavior changed status:confirmed This issue has been reviewed and confirmed type:bug Something isn't working
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

fix: avoid output flood when scanning repo GitGuardian/ggshield
2 participants
@deimosfr @agateau-gg