Fix issue #336 : Rewriting tests without altered cassette #370
Conversation
Kariss83
changed the title
Codecov Report
@@ Coverage Diff @@
## main #370 +/- ##
=======================================
Coverage 94.55% 94.55%
=======================================
Files 75 75
Lines 3231 3231
=======================================
Hits 3055 3055
Misses 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Can you rebase your branch on top of |
…own_error_response
…lls in test_iac_scan_unknown_error_response, test_iac_scan_json_error_response, test_iac_scan_error_response
Kariss83
force-pushed
the
rewriting-tests-without-altered-cassette
branch
from
985e8c3
to
70dc523
Compare
|
@agateau-gg I rebased and everything seems good on my side. It seems that all the checks fail due to functional tests but not mine. Let me know if I missed something. |
|
Yes, that's because the PR comes from a fork and so it does not have access to the required credentials to run the functional tests. We need to look into this. Your code looks good, merging it. Thanks again! |
I created two return mocks that are called and returns errors using the error that was previously in the casette output.
I've decided to put the mocks in
tests/conftest.py, not sure that is the best place, let me know if something is more suitable.