Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease minimum iOS version #46

Merged
merged 4 commits into from Jan 5, 2019
Merged

Conversation

av0c0der
Copy link
Contributor

Create ContextMenuHapticFeedbackStyle enumeration to mirror iOS UIImpactFeedbackGenerator.FeedbackStyle

No changes required if shorthand calls (.light, .medium, .hard) were used. Example project compiles without any change.

Minimum iOS version was first decreased here #35 and then it was set back to iOS 10 here #37

Create ContextMenuHapticFeedbackStyle enumeration to mirror iOS UIImpactFeedbackGenerator.FeedbackStyle
@av0c0der av0c0der changed the title Decrease minium iOS version Decrease minimum iOS version Dec 31, 2018
@av0c0der
Copy link
Contributor Author

av0c0der commented Jan 5, 2019

@rnystrom I have changed the example project a little, specified iOS version, installed newest version of the Pod and unset Signing identity. Do you think it makes sense to push these updates?

@rnystrom
Copy link
Member

rnystrom commented Jan 5, 2019

Ya that’s fine

Sent with GitHawk

- Install newest Pod version
- Specify platform in the Podfile
- Unset development team
@rnystrom rnystrom merged commit 03c33c4 into GitHawkApp:master Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants