Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Display Author in Inbox view #1885

Open
NoahTheDuke opened this issue Jun 25, 2018 · 9 comments
Open

Display Author in Inbox view #1885

NoahTheDuke opened this issue Jun 25, 2018 · 9 comments
Labels
🆕 feature request A feature being requested to be added, not yet approved

Comments

@NoahTheDuke
Copy link

Currently, the issue/pr title, number, and number of comments is shown on the main Inbox view (and in View All). It would be nice to see the author as well, listed in the white space underneath the title. This would mirror the web interface. If you’re feeling frisky, you could also layer the participating profile pics in the same way as the web interface.

@rnystrom rnystrom added the 🆕 feature request A feature being requested to be added, not yet approved label Jun 25, 2018
@rnystrom
Copy link
Member

@NoahTheDuke author that caused the notification, or author of the issue/PR? (Assuming the latter)

Dig the idea, but we have to be careful with space here. Not sure where to put it.

Sent with GitHawk

@NoahTheDuke
Copy link
Author

Author (OP) of the issue/PR.

Currently, in the app Project Issues/PRs view, it mirrors the web interface which is includes labels and is honestly very clunky looking. Leaving out the labels, you could fit the OP underneath the title.

I mocked up an example (below) from a screenshot of "View All" (as I don't have any notifications, lol). Included are three pairs of ideas: The first of each pair shows the time since the issue/PR was opened (which mirrors the app Project Issues/PRs view) and the second does not (just the username of the OP). The first pair is the basic idea, the second and third pairs include the "users who've interacted with this" avatars as listed in the web interface's Notifications page in two different locations.

example

@BasThomas
Copy link
Collaborator

BasThomas commented Jun 25, 2018

I'm worried this will cause a visual overload for little benefit 😕

Thanks for the mockup by the way, that is very helpful!

@NoahTheDuke
Copy link
Author

No worries! Thanks so much for all the hard work you put in!

@BasThomas
Copy link
Collaborator

Didn’t want to close this; it’s just a feeling! 😃

Thanks for bringing up the issue 😊

Sent with GitHawk

@NoahTheDuke
Copy link
Author

My apologies for the quick close, and you're welcome! I wish I had a Mac, cuz I'd love to contribute; I use this app every single day.

@Huddie Huddie mentioned this issue Nov 27, 2018
5 tasks
@dimirc
Copy link

dimirc commented Feb 17, 2019

author that caused the notification, or author of the issue/PR? (Assuming the latter)

@rnystrom I think will be more natural with the author that caused the notification, actually the Github web version works like that and personally this helps me to know what notifications to check first based on who produced them.

On my opinion the author of the Issue/PR shouln't be that important at the Inbox View, as we're checking notifications and not issues/PR, so we want to know who created the former

@dimirc
Copy link

dimirc commented Feb 19, 2019

Pls correct me if I’m wrong but I was checking the source code to try to do a PR for this change and looks like the app is using the v3 REST api to get notifications instead of the v4 graphQL api?

@BasThomas
Copy link
Collaborator

Yeah, that could be. I think there are some discrepancies between the v3 and v4 API in places; this might be the reason. Not entirely sure though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🆕 feature request A feature being requested to be added, not yet approved
Projects
None yet
Development

No branches or pull requests

4 participants