Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Push notification doesn’t mark as read #2298

Open
Huddie opened this issue Oct 16, 2018 · 11 comments
Open

Push notification doesn’t mark as read #2298

Huddie opened this issue Oct 16, 2018 · 11 comments
Labels
🐛 bug Unintended behaviour within the app ❔ question Question pending discussion or card yet to be correctly triaged

Comments

@Huddie
Copy link
Collaborator

Huddie commented Oct 16, 2018

Anyone else?

Sent with GitHawk

@BasThomas BasThomas added the ❔ question Question pending discussion or card yet to be correctly triaged label Oct 16, 2018
@j-f1
Copy link

j-f1 commented Oct 16, 2018

I can repro this too.

@rnystrom
Copy link
Member

Can you explain the issue a little more? What is supposed to be read?

Sent with GitHawk

@j-f1
Copy link

j-f1 commented Oct 16, 2018

When you tap a push notification, the issue/PR isn’t marked as read in GitHawk’s inbox view.

@Huddie
Copy link
Collaborator Author

Huddie commented Oct 16, 2018

Ya what @j-f1 said. Push notifications open you to an issue but even though that means you’ve read the issue, the issue still shows in the inbox

Sent with GitHawk

@BasThomas
Copy link
Collaborator

Yeah it seems to perform the route but the reading logic is here which is probably not being hit via the route.

@rnystrom
Copy link
Member

Oh now I understand. If you have this enabled in settings, it'll work. But otherwise, it doesn't mark read unless you do it from the inbox.

Would you expect this to work as if you marked it read from inbox?

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 4, 2018

I believe even with read on in settings it doesn’t read when opening via push. Anyone else able to confirm?

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Nov 4, 2018

I just confirmed that opening from push does not mark the notification as read.

@rnystrom ya I feel like it should mark it as if read from inbox. Any reason why reading it via push is different from reading via inbox?

Sent with GitHawk

@rnystrom
Copy link
Member

rnystrom commented Nov 4, 2018

Oh snap now I get it. The read logic is all in the notification SC.

Sent with GitHawk

@rnystrom rnystrom added the 🐛 bug Unintended behaviour within the app label Nov 4, 2018
@ghost
Copy link

ghost commented Mar 17, 2019

Other question, you only get notifications when the app runs in the background, right? Otherwise I‘m having a bug.

Sent with GitHawk

@Huddie
Copy link
Collaborator Author

Huddie commented Mar 17, 2019

Yes thats correct

Sent with GitHawk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Unintended behaviour within the app ❔ question Question pending discussion or card yet to be correctly triaged
Projects
None yet
Development

No branches or pull requests

4 participants