Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

[VISION] Auth, login & bookmark refactor #2376

Closed
10 tasks
ijm8710 opened this issue Nov 1, 2018 · 7 comments
Closed
10 tasks

[VISION] Auth, login & bookmark refactor #2376

ijm8710 opened this issue Nov 1, 2018 · 7 comments
Labels
🆕 feature request A feature being requested to be added, not yet approved

Comments

@ijm8710
Copy link

ijm8710 commented Nov 1, 2018

The following referenced tickets can be closed:
#2379 #2377 #1886 #2441 #2302 #2165

@rnystrom rnystrom added the 🆕 feature request A feature being requested to be added, not yet approved label Nov 1, 2018
@rnystrom
Copy link
Member

rnystrom commented Nov 1, 2018

Oh interesting. I bet we could bundle all of it in the next update:

  • Bookmark sync
  • Selective logout
  • Fix login scopes
  • Add PAT to auth

I think that’d tell a cool story for one update!

Sent with GitHawk

@rnystrom
Copy link
Member

Ya I’d like to get the login enhancements in a future version once the refactor noise quiets down. Can always use help.

Sent with GitHawk

@ijm8710 ijm8710 changed the title Ability to reapply edited personal access token to logged in account [VISION] Auth, login & bookmark enhancements Nov 21, 2018
@ijm8710 ijm8710 changed the title [VISION] Auth, login & bookmark enhancements [VISION] Auth, login & bookmark refactor Nov 21, 2018
@ijm8710
Copy link
Author

ijm8710 commented Nov 21, 2018

@rnystrom I laid everything out more condensed and on one ticket (since they’re all interlinked). Hopefully you agree this makes it more linear and easier to follow. 😉

@ghost
Copy link

ghost commented Nov 28, 2018

I found this repository today by @intellum. It might be useful to you.

Their recent work on this repo has broken two example projects nested in the root dir. So I submitted a PR to get the 'intermediate' example project running.

Checkout the code here and navigate to Root/Examples/Intermediate and run carthage bootstrap there.

untitled 2018-11-28 16_46_31

@ijm8710
Copy link
Author

ijm8710 commented Nov 28, 2018

@rob-nash is that a wrapper of the mobile site or an app?

@ghost
Copy link

ghost commented Nov 28, 2018

@ijm8710 wrapper around WKWebView

@rnystrom
Copy link
Member

Closing this as its just a summary of already-tracked issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🆕 feature request A feature being requested to be added, not yet approved
Projects
None yet
Development

No branches or pull requests

2 participants