Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

PR Reviewers changes apply when tapping on an empty space #2582

Open
ismetanin opened this issue Jan 3, 2019 · 2 comments
Open

PR Reviewers changes apply when tapping on an empty space #2582

ismetanin opened this issue Jan 3, 2019 · 2 comments
Labels
👍 feature approved Features approved for implementation ✨ good first issue An issue suitable for someone looking to get familiar with the codebase

Comments

@ismetanin
Copy link
Member

Describe the bug
PR Reviewers changes apply when tapping on an empty space.

To Reproduce

  1. Go to any PR
  2. Click on the floating button
  3. Click on the "Reviewers" button
  4. Change reviewers list
  5. Tap on the empty space outside of the dialog
  6. See changes in Reviewers of a PR

Expected behavior
When I tap on the empty space I wanna discard all changes and close dialog. Or maybe do nothing.

Screenshots
img_3235

Smartphone:

  • Device: iPhone 6s
  • OS: iOS 12
  • Browser Safari
  • Version 1.25.0
@rnystrom rnystrom added the 👍 feature approved Features approved for implementation label Jan 3, 2019
@rnystrom
Copy link
Member

rnystrom commented Jan 3, 2019

Happy to change the design here so there is an explicit “are you sure?” dialog when cancelling after changes.

Sent with GitHawk

@rnystrom rnystrom added the ✨ good first issue An issue suitable for someone looking to get familiar with the codebase label Jan 3, 2019
@BasThomas
Copy link
Collaborator

I feel that this is a bit trickier, as eg. labels or assignees should then also mimic this behavior. Not sure if it makes sense for labels, however; but having different behavior for different "entities" feels like an even worse user experience. Thoughts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
👍 feature approved Features approved for implementation ✨ good first issue An issue suitable for someone looking to get familiar with the codebase
Projects
None yet
Development

No branches or pull requests

3 participants