Native Create Issue #311

Sherlouk · 2017-09-15T23:05:05Z

Closes #288
Closes #350

Created view controller to natively create an issue supporting a title and body text
Pass through the correct GithubClient to Settings VC (necessary for correct authentication)
Updated "Report a bug" tool to use issue creator (currently using a test repo)
On a successful creation, the user is segued to the issues view controller (replacing new issue, so they can't go back to the form!)

Example output: rnystromtest/Githawk-Playground#2
Used API: https://developer.github.com/v3/issues/#create-an-issue

…reporting

Sherlouk · 2017-09-16T10:48:10Z

Added new issue button to all repositories that have issue enabled
Added markdown/action bar
Added a separate preview button (Wanted to put the actual preview in the same box but turn off editing, but this was too difficult so I kept it simple and pushed it out the same VC we use at comment level)
Fixed issues on tablet so things appear in the correct panel
Fully localized now
Keyboard will now update the insets in the scroll view
Pressing "return" when in the title field, will take you to the body field
Body field will expand as new lines are added

Still looks like 💩 - If anyone wants to give a hand making it look nice I would appreciate it 😅

…view, return takes you to next field

Sherlouk · 2017-09-16T14:03:24Z

I'd say for an initial implementation I'm happy with it now - Obviously we can add new functionality down the line for adding labels, assignees etc (assuming you have push permissions) but I think this is good?

BasThomas · 2017-09-16T15:16:28Z

Regarding design: a few years back I did something similar regarding native reporting, and think that looked pretty nice. Obviously a bit different in comparison with creating an issue, but design wise you get the idea.

Sherlouk · 2017-09-16T16:47:40Z

@BasThomas You're more than welcome to branch off and try match that!

It looks a look more modular, and similar to Eureka just couldn't see a nice way of doing it without ballooning hence with the simpler scroll view

rnystrom · 2017-09-17T21:12:55Z

Will give this a deeper look soon, def need to massage the design. I personally prefer the look of the stuff @BasThomas posted: grouped UITableView style, tho it might be overkill for title+body. I'm not sure yet the best way to incorporate the editing tools. Input accessory view is prob the best bet for this.

Sherlouk · 2017-09-17T21:22:16Z

Design has never been a hotspot of mine, and editing tools are definitely up for discussion (I basically just copied what we had already to minimise on work!)

This does look quite nice though: http://1writerapp.com/
In essence a custom keyboard

If someone wants to pick up the design then I'd be appreciative - otherwise I can try and copy BasThomas' design above

BasThomas · 2017-09-21T16:31:29Z

Probably also want to add this option for repos you’re browsing via search. Will create a separate issue.

Sherlouk · 2017-09-21T16:37:42Z

This is available via search and for report a bug - am I missing something @BasThomas

_{Sent with GitHawk}

BasThomas · 2017-09-22T05:16:30Z

I don’t get it. 😬 What are you referring to?

I am expecting, if you look at the screenshot below, to also have an option to “Open an Issue”

Sherlouk · 2017-09-22T06:53:20Z

Classes/Repository/RepositoryViewController.swift

@@ -48,6 +48,30 @@ PrimaryViewController {
        feed.viewDidLoad()
        feed.adapter.dataSource = self
        title = "\(repo.owner)/\(repo.name)"
+
+        if repo.hasIssuesEnabled {
+            navigationItem.rightBarButtonItem = UIBarButtonItem(


@BasThomas You mean like this code here 😉

I know I need to move it to the action sheet, but the logic is all here to have a "New Issue" button for the repo view controller - Just don't merge master into this branch 😂

# Conflicts: # Classes/Repository/RepositoryViewController.swift # Resources/Info.plist

Sherlouk · 2017-09-22T18:05:58Z

@rnystrom Just updated with changes in master so the "Create Issue" is now in the overflow rather than it's own button

In terms of design, https://github.com/xmartlabs/Eureka would give us a basic form with all the structure done for us -- Would this be a solution you're okay with?

rnystrom · 2017-09-22T18:10:15Z

Is that project gonna be overkill tho? Will we use it for more stuff in the future? Nervous about taking another dependency for a simple design.

_{Sent with GitHawk}

Sherlouk · 2017-09-22T18:12:13Z

Further down the line I'm sure the form will get more complicated with files/images, labels, assignees, etc

Other forms include add/edit projects, maybe even editing repos

I'll give it a quick go now without Eureka and see how it ends up

Sherlouk · 2017-09-22T18:48:15Z

@rnystrom

You mentioned before that we need to come up with a better way of doing markdown so I left the buttons out of this design. Is this what you had in mind?

Sherlouk · 2017-09-22T20:18:59Z

cc @BasThomas ^^ also

rnystrom · 2017-09-22T23:33:51Z

Ya that looks pretty great, nice and simple. We should be able to add the markdown actions as the input accessory view, right? @Sherlouk can you confirm that's still possible here?

Sherlouk · 2017-09-23T08:15:20Z

It should still be possible yea (it’s just a text view!) will look into it

_{Sent with GitHawk}

# Conflicts: # Classes/Repository/RepositoryViewController.swift # Resources/Info.plist

Sherlouk · 2017-09-23T09:23:06Z

Added markdown controls ^^

@rnystrom @BasThomas

rnystrom · 2017-09-23T12:10:11Z

Yessss!

Sherlouk · 2017-09-23T12:25:44Z

@rnystrom We waiting on anything to merge this now? 😄

BasThomas · 2017-09-23T13:05:44Z

Nice!

rnystrom · 2017-09-23T13:30:24Z

@Sherlouk don’t think so! I’ll give the code a quick look, but I also don’t mind refactoring anything on my own. Will merge today!

_{Sent with GitHawk}

Sherlouk · 2017-09-25T08:19:31Z

@rnystrom Hit me up when ready to merge and I can deal with the conflicts

rnystrom · 2017-09-25T14:30:28Z

@Sherlouk give it a go and DM me on Twitter so I can merge ASAP to avoid more conflicts!

Sherlouk · 2017-09-25T15:09:57Z

@rnystrom Picking this up now, will be 5 minutes

# Conflicts: # Classes/Repository/RepositoryViewController.swift # Classes/Settings/SettingsViewController.swift # Resources/Info.plist

Sherlouk · 2017-09-25T15:12:28Z

All good!

weyert · 2017-09-27T09:30:10Z

May I ask why you have chosen a UITableView for this and not a UICollectionView or let's go wild and a UIStackView? I am still trying to find out when to use what. I really like UICollectionView myself as it's more powerful with it custom layout's support.

Sherlouk · 2017-09-27T10:00:58Z

Originally it was a UIScrollView with a couple elements in, ultimately I would've been happy with a bit of auto layout magic but crucially we still needed to support all the screen sizes so scrolling was a must

In the end it came down to simplicity and "out of the box" design. A grouped UITableView gives us a consistent design not only across the app but also familiarity across iOS. Using static cells makes it super easy to implement and all values can be accessed without the need for a maze of delegates and hierarchy calls.

In this situation there was very little flexibility required, though when we do get the point of adding additional fields, such as labels, this may have to change.

Sherlouk added 4 commits September 16, 2017 00:01

Add a "Create Issue" view controller, Hook up networking, Enable bug …

05dbf65

…reporting

Add create issue button to all repos

53ca2ca

Fix navigation for tablet, Add markdown controls view

fc80ca8

Remove new issue button if issues are not enabled

411f816

Sherlouk added 4 commits September 16, 2017 11:54

Add localization for new issue text

0547102

Update scrollView insets on keyboard, Add slight background

6062734

More style changes, moved preview to it's own button, expanding text …

ce403cd

…view, return takes you to next field

Update bug report repository

fe49eac

Sherlouk requested a review from rnystrom September 16, 2017 14:03

Sherlouk mentioned this pull request Sep 17, 2017

Add a network responses dump to debug logs #71

Open

rnystrom mentioned this pull request Sep 21, 2017

Create issue on project #350

Closed

Sherlouk commented Sep 22, 2017

View reviewed changes

Merge remote-tracking branch 'origin/master' into newIssue

b41a172

# Conflicts: # Classes/Repository/RepositoryViewController.swift # Resources/Info.plist

Design changes

1e934c9

Sherlouk added 2 commits September 23, 2017 10:00

Merge remote-tracking branch 'origin/master' into newIssue

3084003

# Conflicts: # Classes/Repository/RepositoryViewController.swift # Resources/Info.plist

Add markdown controls to new issue

c0f0d2c

Sherlouk requested a review from BasThomas September 23, 2017 09:23

Sherlouk changed the title ~~WIP: Native Create Issue~~ Native Create Issue Sep 23, 2017

Merge branch 'master' into newIssue

0b32bcf

Merge remote-tracking branch 'origin/master' into newIssue

e3ecb84

# Conflicts: # Classes/Repository/RepositoryViewController.swift # Classes/Settings/SettingsViewController.swift # Resources/Info.plist

rnystrom merged commit f40557e into master Sep 25, 2017

Sherlouk deleted the newIssue branch September 26, 2017 08:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Native Create Issue #311

Native Create Issue #311

Sherlouk commented Sep 15, 2017 •

edited

Sherlouk commented Sep 16, 2017 •

edited

Sherlouk commented Sep 16, 2017

BasThomas commented Sep 16, 2017

Sherlouk commented Sep 16, 2017

rnystrom commented Sep 17, 2017 •

edited

Sherlouk commented Sep 17, 2017 •

edited

BasThomas commented Sep 21, 2017

Sherlouk commented Sep 21, 2017

BasThomas commented Sep 22, 2017 •

edited

Sherlouk Sep 22, 2017

Sherlouk commented Sep 22, 2017

rnystrom commented Sep 22, 2017

Sherlouk commented Sep 22, 2017

Sherlouk commented Sep 22, 2017

Sherlouk commented Sep 22, 2017 •

edited

rnystrom commented Sep 22, 2017

Sherlouk commented Sep 23, 2017 •

edited

Sherlouk commented Sep 23, 2017

rnystrom commented Sep 23, 2017

Sherlouk commented Sep 23, 2017

BasThomas commented Sep 23, 2017

rnystrom commented Sep 23, 2017

Sherlouk commented Sep 25, 2017

rnystrom commented Sep 25, 2017

Sherlouk commented Sep 25, 2017

Sherlouk commented Sep 25, 2017

weyert commented Sep 27, 2017

Sherlouk commented Sep 27, 2017

Native Create Issue #311

Native Create Issue #311

Conversation

Sherlouk commented Sep 15, 2017 • edited

Sherlouk commented Sep 16, 2017 • edited

Sherlouk commented Sep 16, 2017

BasThomas commented Sep 16, 2017

Sherlouk commented Sep 16, 2017

rnystrom commented Sep 17, 2017 • edited

Sherlouk commented Sep 17, 2017 • edited

BasThomas commented Sep 21, 2017

Sherlouk commented Sep 21, 2017

BasThomas commented Sep 22, 2017 • edited

Sherlouk Sep 22, 2017

Choose a reason for hiding this comment

Sherlouk commented Sep 22, 2017

rnystrom commented Sep 22, 2017

Sherlouk commented Sep 22, 2017

Sherlouk commented Sep 22, 2017

Sherlouk commented Sep 22, 2017 • edited

rnystrom commented Sep 22, 2017

Sherlouk commented Sep 23, 2017 • edited

Sherlouk commented Sep 23, 2017

rnystrom commented Sep 23, 2017

Sherlouk commented Sep 23, 2017

BasThomas commented Sep 23, 2017

rnystrom commented Sep 23, 2017

Sherlouk commented Sep 25, 2017

rnystrom commented Sep 25, 2017

Sherlouk commented Sep 25, 2017

Sherlouk commented Sep 25, 2017

weyert commented Sep 27, 2017

Sherlouk commented Sep 27, 2017

Sherlouk commented Sep 15, 2017 •

edited

Sherlouk commented Sep 16, 2017 •

edited

rnystrom commented Sep 17, 2017 •

edited

Sherlouk commented Sep 17, 2017 •

edited

BasThomas commented Sep 22, 2017 •

edited

Sherlouk commented Sep 22, 2017 •

edited

Sherlouk commented Sep 23, 2017 •

edited