Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Support for filtering/grouping of notifications by repository #61

Closed
indyfromoz opened this issue Jul 5, 2017 · 8 comments
Closed

Support for filtering/grouping of notifications by repository #61

indyfromoz opened this issue Jul 5, 2017 · 8 comments

Comments

@indyfromoz
Copy link

Freetime currently displays a list of notifications from a user's public repositories (notifications from private repositories are currently not displayed, see #60 for a discussion). These notifications are ordered via their timestamp in chronological order. The list may contain several hundred read/unread notifications.

It will be great if we could apply a "filter" to select one or more repositories the user is subscribed for notifications and show notifications from only the selected repositories. In addition, notifications can possibly be grouped by repositories 🤔 . This will probably make things complicated as we would want pagination of notifications.

image

@rnystrom
Copy link
Member

rnystrom commented Jul 5, 2017

I actually had this originally but pulled it b/c of paging. It's a great idea tho. I could add a new segment that is like "Repos" that groups them or something.

I can also request notifications per repo.

@indyfromoz
Copy link
Author

indyfromoz commented Jul 5, 2017

Having a segment for repositories will be awesome! I see two major benefits -

  1. List of repositories user is currently receiving notifications for, along with basic metadata for each repository.
  2. A quick menu or a shortcut associated with each repository that one can use to show/hide notifications within the "Unread" (perhaps even the "All) segment.

@rnystrom
Copy link
Member

I think we can use the same design from #1267 and display a dropdown of all your watched repositories. Tapping one pushes a new VC of notifications only for that repo.

Sent with GitHawk

@BasThomas
Copy link
Collaborator

BasThomas commented Dec 18, 2017

What about doing what GitHub does, sorting per repo and ordering by last updated? Should also be pretty easy to do (and we can make this an option in Settings in case we want to keep the current situation as a possibility).

@rnystrom
Copy link
Member

Thats actually how it worked back in the Freetime days.

Paging becomes really complicated and confusing. That, or we have to send separate requests for each repo you watch, and that gets gross fast (dealing with errors).

The biggest lesson I’ve learned in building this app is to not try to bend the API. Make the UI reflect how the API works and what it provides. Then the code and UI is stays simple.

Sent with GitHawk

@BasThomas
Copy link
Collaborator

I mean we can just group what we get from the API?

@rnystrom
Copy link
Member

That’s the paging complexity I was talking about. If we put a single “load more” at the bottom, then on update the different sections get filled in, gets really confusing to use.

Sent with GitHawk

@BasThomas
Copy link
Collaborator

What about not supporting paging when sorting? Do you think that would be too niche? It would work for me, as I frequently visit the site and clean up my notifications 😇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants