When you update the GUI related file in the repo, can you update the wxSmith file accordingly

[asmwarrior]

Hi, I see you have update some GUI related file, but it looks like the wxSmith file is not updated accordingly.

Can you also updating this .wxs file? Because I think the GUI file is generated from the wxSmith file.

BTW: I'm not sure, but why are you update the file by uploading the files to github, I think a normal git commit/push is much simple and better, and easy to track the changes.

Thanks.

[GitHubLionel]

Hi,

Ok, I have cleaned the files (suppress un-necessary, rename, add sample and binary to quickly see the component).

I am not familiar with github on console, so upload from browser is more simple for me. But I install a GitHub GUI and it's now easy to push files.

Regards,
Lionel

[asmwarrior]

Hi, I think the correct and standard git client is: Git for Windows. You can just use the git add/commit/push command through the command line or the git gui GUI tool.

I haven't used GitHub GUI before.

The file .depend is also not needed in the git repo, this file is generated by Code::Blocks for tracking the compiler dependency for each files.

There is another issue, I think the generated exe/dll binary files should be put in the Release section of the github page. (You can upload the zip file as the release) Those binaries are not suitable to put inside the git repo.

[GitHubLionel]

Hi,
I tried "GitHub Desktop" and work fine (I would like a French translation, but it's ok).
The binary is just the sample exe if somebody want to quickly test. I don't know where is the Release section.
Regards,
Lionel

[asmwarrior]

The binary is just the sample exe if somebody want to quickly test. I don't know where is the Release section. Regards, Lionel

Hi, you can look at this github document:
https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository

[GitHubLionel]

This is done.

[asmwarrior]

This is done.

Thanks!

One more question, I see there are two MathPlotConfig.cpp files:

One is

https://github.com/GitHubLionel/wxMathPlot/blob/master/MathPlotConfig/MathPlotConfig.cpp

Another file is:

https://github.com/GitHubLionel/wxMathPlot/blob/master/mathplot/MathPlotConfig.cpp

Does the two MathPlotConfig.cpp were all generated from the same wxSmith file (https://github.com/GitHubLionel/wxMathPlot/blob/master/MathPlotConfig/wxsmith/MathPlotConfigdialog.wxs) ?

Thanks.

[GitHubLionel]

Yes the two are generated with the same wxSmith file, but I made a small change in the file in the mathplot directory in the events section. I change "(wxObjectEventFunction)&" to "wxCommandEventHandler(" because I have a warning in Eclipse IDE.

[asmwarrior]

OK, thanks for the reply.

Do you mean that this is a wxSmith generation error? if that is true, I think we can change the wxSmith source code to generate the correct code.

[GitHubLionel]

Hi,

It is not an error but a warning like this one :
cast between incompatible pointer to member types from 'void (MyFrame::*)(wxCommandEvent&)' to 'wxObjectEventFunction' {aka 'void (wxEvtHandler::*)(wxEvent&)'} [-Wcast-function-type]
So to avoid this warning, I change the code.
Note that I use wxWidget 3.2.1. Maybe it was correct in an older version.
Maybe, replace connect() by bind() will be a better solution.

[asmwarrior]

Hi,

It is not an error but a warning like this one : cast between incompatible pointer to member types from 'void (MyFrame::*)(wxCommandEvent&)' to 'wxObjectEventFunction' {aka 'void (wxEvtHandler::*)(wxEvent&)'} [-Wcast-function-type] So to avoid this warning, I change the code. Note that I use wxWidget 3.2.1. Maybe it was correct in an older version. Maybe, replace connect() by bind() will be a better solution.

Oh, it looks like I don't see this kind of warning in my Code::Blocks.

BTW, it looks like you are not using the latest Code::Blocks, so the wxSmith generated code are slightly different between mine and yours.
You can see this commit in my fork of your repo.

newer wxSmith will automatically update the generated code by adding …

The latest Code::Blocks can be downloaded from the nightly build forum: Nightly builds