Skip to content

Commit

Permalink
Always use dart-git for merges
Browse files Browse the repository at this point in the history
I'm going to be moving away from libgit2 for the next release, and while
my own dart-git's merging is quite bad in comparison to libgit2, it's
the only way to move forward without libgit2.

The cross-compilation and all is too much of a pain for me to continue
using it. I haven't had an iOS release in over a year because of it.
Plus it sucks all the fun out this project.

Fixes #934
  • Loading branch information
vHanda committed Dec 6, 2023
1 parent df07bd3 commit 80cbb05
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 34 deletions.
23 changes: 5 additions & 18 deletions lib/core/git_repo.dart
Original file line number Diff line number Diff line change
Expand Up @@ -235,24 +235,11 @@ class GitNoteRepository {
rethrow;
}

if (useDartGit || AppConfig.instance.experimentalGitMerge) {
var author = GitAuthor(
email: config.gitAuthorEmail,
name: config.gitAuthor,
);
return repo.mergeCurrentTrackingBranch(author: author);
}

try {
await _gitRepo.merge(
branch: branchConfig.remoteTrackingBranch(),
authorEmail: config.gitAuthorEmail,
authorName: config.gitAuthor,
);
} on gb.GitException catch (ex, stackTrace) {
Log.e("Git Merge Failed", ex: ex, stacktrace: stackTrace);
rethrow;
}
var author = GitAuthor(
email: config.gitAuthorEmail,
name: config.gitAuthor,
);
return repo.mergeCurrentTrackingBranch(author: author);
}

Future<void> push() async {
Expand Down
1 change: 0 additions & 1 deletion lib/l10n/app_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@
"settingsExperimentalAccounts": "Platform Independent Accounts",
"settingsExperimentalIncludeSubfolders": "Include Subfolders",
"settingsExperimentalExperimentalGitOps": "Dart-only Git implementation",
"settingsExperimentalMerge": "Dart-only merge implementation",
"settingsExperimentalAutoCompleteTags": "Tags Auto Completion",
"settingsExperimentalHistory": "History View",
"settingsEditorsTitle": "Editor Settings",
Expand Down
6 changes: 0 additions & 6 deletions lib/settings/app_config.dart
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ class AppConfig extends ChangeNotifier {
var experimentalSubfolders = false;
var experimentalMarkdownToolbar = false;
var experimentalAccounts = false;
var experimentalGitMerge = false;
var experimentalGitOps = false;
var experimentalTagAutoCompletion = false;

Expand All @@ -55,8 +54,6 @@ class AppConfig extends ChangeNotifier {
experimentalMarkdownToolbar;
experimentalAccounts =
pref.getBool("experimentalAccounts") ?? experimentalAccounts;
experimentalGitMerge =
pref.getBool("experimentalGitMerge") ?? experimentalGitMerge;
experimentalGitOps =
pref.getBool("experimentalGitOps") ?? experimentalGitOps;
experimentalTagAutoCompletion =
Expand Down Expand Up @@ -85,8 +82,6 @@ class AppConfig extends ChangeNotifier {
defaultSet.experimentalMarkdownToolbar);
_setBool(pref, "experimentalAccounts", experimentalAccounts,
defaultSet.experimentalAccounts);
_setBool(pref, "experimentalGitMerge", experimentalGitMerge,
defaultSet.experimentalGitMerge);
_setBool(pref, "experimentalGitOps", experimentalGitOps,
defaultSet.experimentalGitOps);
_setBool(
Expand All @@ -112,7 +107,6 @@ class AppConfig extends ChangeNotifier {
'debugLogLevel': debugLogLevel,
'experimentalMarkdownToolbar': experimentalMarkdownToolbar.toString(),
'experimentalAccounts': experimentalAccounts.toString(),
'experimentalGitMerge': experimentalGitMerge.toString(),
'experimentalGitOps': experimentalGitOps.toString(),
'experimentalTagAutoCompletion': experimentalTagAutoCompletion.toString(),
'experimentalHistory': experimentalHistory.toString(),
Expand Down
9 changes: 0 additions & 9 deletions lib/settings/settings_experimental.dart
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,6 @@ class _ExperimentalSettingsScreenState
setState(() {});
},
),
SwitchListTile(
title: Text(context.loc.settingsExperimentalMerge),
value: appConfig.experimentalGitMerge,
onChanged: (bool newVal) {
appConfig.experimentalGitMerge = newVal;
appConfig.save();
setState(() {});
},
),
SwitchListTile(
title: Text(context.loc.settingsExperimentalExperimentalGitOps),
value: appConfig.experimentalGitOps,
Expand Down

0 comments on commit 80cbb05

Please sign in to comment.