Add sealed classes support to serialization

[LarsArtmann]

Could you add support of "sealed" class to the FirebaseDecoder.structureDecoder and FirebaseEncoder.structureEncoder functions?

I would try it with some think like this:

fun FirebaseEncoder.structureEncoder(descriptor: SerialDescriptor, @Suppress("UNUSED_PARAMETER") vararg typeParams: KSerializer<*>): CompositeEncoder = when(descriptor.kind) {
    StructureKind.LIST, PolymorphicKind.SEALED -> mutableListOf<Any?>()
        .also { value = it }
        .let { FirebaseCompositeEncoder(shouldEncodeElementDefault, positiveInfinity) { _, index, value -> it.add(index, value) } }
    StructureKind.MAP -> mutableListOf<Any?>()
        .let { FirebaseCompositeEncoder(shouldEncodeElementDefault, positiveInfinity, { value = it.chunked(2).associate { (k, v) -> k to v } }) { _, _, value -> it.add(value) } }
    StructureKind.CLASS,  StructureKind.OBJECT -> mutableMapOf<Any?, Any?>()
        .also { value = it }
        .let { FirebaseCompositeEncoder(shouldEncodeElementDefault, positiveInfinity) { _, index, value -> it[descriptor.getElementName(index)] = value } }
    else -> TODO("The firebase-kotlin-sdk does not support $descriptor for serialization yet")
}

This case is optimized for plain Kotlin.

Unfortunately, I also have some building problems too, so I cannot implement them myself

[nbransby]

What are the building problems you are having?

[LarsArtmann]

lint is failing

[nbransby]

What lint?

[LarsArtmann]

idk, that's the error message:

Execution failed for task ':firebase-firestore:lint'.
> Lint found errors in the project; aborting build.

[nbransby]

I have not seen this before! is there a way to get the log of lint errors?

[LarsArtmann]

That's the only thing gradle prints out to the console.
Cloud it is possible that it is a problem with Intelijj and I need to use Android Studio?

[nbransby]

No, I use IJ but anyway its gradle issue so shouldn't be affected by IDE try running the task with --info

[nbransby]

Ok I recreated the issue by running the lint task directly - what gradle task were you running?

[LarsArtmann]

gradle build in firebase-firestore

[nbransby]

Pull latest master - should fix your issue

[LarsArtmann]

Now I have this problem: "Expected function 'runTest' has no actual declaration in module firebase-firestore.iosArm64Test~1 (test) for Native"

PS: I use Windows 10

[nbransby]

The error is the screenshot is different, are you using the master branch? It says not defined for JVM target but there is no JVM target

[LarsArtmann]

Yes I pulled the master branch and merged it with the local changes

[nbransby]

What local changes do you have?

[LarsArtmann]

Now I have done, a hard reset to the latest commit on the master branch.
That was my result:

(I just run firebase-firestore build on IntelliJ 2020.2 Ultimate with Gradle version 5.6.4)

[nbransby]

Still complaining about JVM platform which we dont have a target setup for so still have no idea how you are getting this error

[nbransby]

I reproduced this error by running the build task in happens in the task ':firebase-app:compileDebugUnitTestKotlinAndroid' which makes sense as its trying to run uninstrumented android tests on the jvm. Thing is we dont have any uninstrumented android tests and im not sure how to stop it from doing this.

Workaround is to run the assemble task instead, thats what the CI does

[nbransby]

btw build is working now too

[walkingbrad]

Hey y'all. Is this a fix we can get back into in the pipeline? I just started using this library (which has worked pretty great so far) but there are couple of hitches such as the inability to deserialize to a sealed class (which I might expect is a fairly common expectation today).

[nbransby]

closing as support has been added

[walkingbrad]

This made my day/week! Thank you all for the time/effort!