🔇 Added an option to disable annoying feedback SFX (#455)

This option can be useful for people who would like to keep the sound style of eDEX-UI, but who are annoyed by constant clicking.
GitSquared · Mar 9, 2019 · 489bd26 · 489bd26
1 parent 4dad3ef
commit 489bd26
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 16 deletions.
diff --git a/src/_boot.js b/src/_boot.js
@@ -71,6 +71,7 @@ if (!fs.existsSync(settingsFile)) {
         theme: "tron",
         termFontSize: 15,
         audio: true,
+        disableFeedbackAudio: false,
         pingAddr: "1.1.1.1",
         port: 3000,
         nointro: false,

diff --git a/src/_renderer.js b/src/_renderer.js
@@ -621,6 +621,14 @@ window.openSettings = async () => {
                             <option>${!window.settings.audio}</option>
                         </select></td>
                     </tr>
+                    <tr>
+                        <td>disableFeedbackAudio</td>
+                        <td>Disable recurring feedback sound FX (input/output, mostly)</td>
+                        <td><select id="settingsEditor-disableFeedbackAudio">
+                            <option>${window.settings.disableFeedbackAudio}</option>
+                            <option>${!window.settings.disableFeedbackAudio}</option>
+                        </select></td>
+                    </tr>
                     <tr>
                         <td>port</td>
                         <td>Local port to use for UI-shell connection</td>
@@ -722,6 +730,7 @@ window.writeSettingsFile = () => {
         theme: document.getElementById("settingsEditor-theme").value,
         termFontSize: Number(document.getElementById("settingsEditor-termFontSize").value),
         audio: (document.getElementById("settingsEditor-audio").value === "true"),
+        disableFeedbackAudio: (document.getElementById("settingsEditor-disableFeedbackAudio").value === "true"),
         pingAddr: document.getElementById("settingsEditor-pingAddr").value,
         port: Number(document.getElementById("settingsEditor-port").value),
         monitor: Number(document.getElementById("settingsEditor-monitor").value),

diff --git a/src/classes/audiofx.class.js b/src/classes/audiofx.class.js
@@ -4,35 +4,37 @@ class AudioManager {
         const {Howl, Howler} = require("howler");
 
         if (window.settings.audio === true) {
-            this.stdout = new Howl({
-                src: [path.join(__dirname, "assets", "audio", "stdout.wav")],
-                volume: 0.4
-            });
-            this.stdin = new Howl({
-                src: [path.join(__dirname, "assets", "audio", "stdin.wav")],
-                volume: 0.4
+            if(window.settings.disableFeedbackAudio === false) {
+                this.stdout = new Howl({
+                    src: [path.join(__dirname, "assets", "audio", "stdout.wav")],
+                    volume: 0.4
+                });
+                this.stdin = new Howl({
+                    src: [path.join(__dirname, "assets", "audio", "stdin.wav")],
+                    volume: 0.4
+                });
+                this.folder = new Howl({
+                    src: [path.join(__dirname, "assets", "audio", "folder.wav")]
+                });
+                this.granted = new Howl({
+                    src: [path.join(__dirname, "assets", "audio", "granted.wav")]
+                });
+            }
+            this.keyboard = new Howl({
+                src: [path.join(__dirname, "assets", "audio", "keyboard.wav")]
             });
             this.theme = new Howl({
                 src: [path.join(__dirname, "assets", "audio", "theme.wav")]
             });
             this.expand = new Howl({
                 src: [path.join(__dirname, "assets", "audio", "expand.wav")]
             });
-            this.keyboard = new Howl({
-                src: [path.join(__dirname, "assets", "audio", "keyboard.wav")]
-            });
             this.panels = new Howl({
                 src: [path.join(__dirname, "assets", "audio", "panels.wav")]
             });
             this.scan = new Howl({
                 src: [path.join(__dirname, "assets", "audio", "scan.wav")]
             });
-            this.folder = new Howl({
-                src: [path.join(__dirname, "assets", "audio", "folder.wav")]
-            });
-            this.granted = new Howl({
-                src: [path.join(__dirname, "assets", "audio", "granted.wav")]
-            });
             this.denied = new Howl({
                 src: [path.join(__dirname, "assets", "audio", "denied.wav")]
             });