-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
Use project.json instead of packages.config Stop linking assemblies together and embedding executables.
Also replace cmdline parsing Rip out MSBuild-oriented Linker method
Now the pdb.srcsrv file actually works. The debugger can download files.
Command line switches can provide all the necessary information.
I added an additional task to merge #132 once that is completed. |
Sorry for my late replies, but the holidays are coming up so deadlines are popping up everywhere. |
No problem. Thanks. I'll work on removing the read only source tree. If I've done my work well, hopefully it is as simple as removing the nuget package. |
Per request of GitLink folks as part of merging PR GitTools#110
OK, my develop branch no longer has the readonlysourcetree package. Removing that dependency was the only change I needed to make, plus to appveyor.yml so that it would still find the nupkg to package as an artifact. |
I've modified from their original to be more reliable to paths with spaces, require at least MSBuild 14 (because that's the only thing tested), and clean build outputs from the new location
I've brought back the build scripts. |
It's support for a new provider (UNC paths). I will merge it now. |
OK, then I guess my next task will be to resolve merge conflicts. |
Merge conflicts resolved. It's just GitVersion holding the merge back now, I think. |
@gep13 are you on holidays? Otherwise I will pick the GitVersion thing up in the first week of January. |
@GeertvanHorrik I am on holiday now, yes (i.e. have some time off work) however, I am full of the cold/flu, so won't be looking at this for at least a couple days. I will let you know if I get a chance to have a look. |
I just had a quick scan, what is the GitVersion issue holding this back? |
I don't think that there is anything holding it back, it just needs to get done. I haven't had the cycles to sit down and add it into the build process yet. |
@JakeGinnivan nothing in GV is holding this back, what @AArnott meant was that we need to apply GV to GitLink (on this specific PR), hence the "GV issue". We will just use the latest stable version for now. |
@AArnott this is fully done except for the GitVersion stuff? Then I will release a new stable version of GL and merge this into develop. |
GitLink 2.4.0 has been released, we are ready to merge this if @AArnott gives the go ahead. This will become 3.*. I will update GV on the develop branch once merged. |
Yes, this is ready. Thanks. |
Sorry it took so long for me to reply with the go ahead. |
Merged, this is a major step forwards. Thanks for all the effort @AArnott . We will now slowly "fix" all the missing pieces and start doing prereleases. |
Awesome. |
@AArnott does this mean that from now on PdbGit will be "obsolete"? |
@kzu Yes, once GitLink 3.x ships. I'm assuming that GitLink 3.0 retains the characteristic that I added in this PR that when you install it to an MSBuild project, it immediately "just works". Because to me that is very important. No build authoring should be required to activate this. |
Agreed. The CI build is currently broken , unfortunately :( |
This PR is a significant refactoring of both code and how functionality is exposed. This includes:
Noteworthy other changes
Remaining work
Write new unit tests to cover the new entrypoints. No new test holes were created in this PR, but I think we can improve our test coverage here.Keep SolutionAssemblyInfo (we can discuss this later, let's focus on the actual issue we are trying to solve here 1 at a time)Closes #104