-
Notifications
You must be signed in to change notification settings - Fork 52
Release note for multiple tags has earliest at the top instead of bottom #23
Comments
Would be happy to provide a pull request if this indeed deemed a problem. |
Oldest should indeed be at the bottom but vNext should be all unreleased and new issues/items? Happy to have a PR anyways if it is not working correctly. I have been refactoring and it needs some love to make it really ready to go (hopefully this week, been distracted with GitVersion) |
It looks like the current HEAD is doing something completely different from the last release (on NuGet.org). The versions are now in the expected order (earliest release at the bottom, latest at the top with vNext above that), but the issues are now all under the incorrect release, while the latest release places them in the right spot. An example from my library from here: https://github.com/pvandervelde/Nuclei Current releasevNext
V0.6.7.0 (23 October 2013)
V0.7.0.0 (04 December 2013)
V0.7.1.0 (21 December 2013)
current HEADvNext
Commits: 76ebf13802...6409b2e74c V0.7.1.0 (21 December 2013)
Commits: 6cbeb3ada2...a341db15ad V0.7.0.0 (04 December 2013)
Commits: 6f8e882b14...1bc23750b9 V0.6.7.0 (23 October 2013)Commits: dacc5de428...55861813f5 V0.6.6.0 (12 October 2013)Commits: 4f9c6a96e3...8bc7d22d72 V0.6.5.0 (26 September 2013)Commits: f90aa2374a...83a270ab2b V0.6.4.0 (21 September 2013)Commits: 4be90ee562...dd6791c6f0 v0.6.3.0 (22 August 2013)Commits: 9ca7f5517e...76e96bc68b v0.6.1.0 (16 August 2013)Commits: 2f407131b5...53d38a9972 I suspect some of the problems with the issues being releated to the wrong releases (for v0.7 and v0.7.1) is because I possibly didn't close the issues until after the release (which is my fault for following a slightly bad process), but the released version of GitReleaseNotes got that right. So in short it seems that the current issue is fixed in HEAD but the current HEAD introduces a new problem in that the issues are not related to the correct releases. So not sure what to do with this issue now. |
Thanks for looking into this! So, the new behaviour is that it will start appending to the releasenotes.md in the root (or whatever you output to) rather than regenerating. This means you can use it to generate it over and over, as well as manually move things into the correct releases/fix titles etc and it will simply append the new closed issues. vNext is basically anything which doesn't fit, and there are probably some issues. vNext should include the current date against it so it knows when it is up to, then it really can just append. I haven't figured out about turning vNext into the next tagged version, which is a large issue. I will try to get back to it over the next week, but feel free to jump in, write tests, suggest behaviour or fix problems :) |
Oh, also pull requests are now included, which may cause more noise than the previous |
Ah right now it makes sense. I still think it would be nice if there was some way to mirror was the current release does, i.e. include issues in those releases where the commits are for if the issue was closed just after the release because I used to close my issues after the release with a comment pointing to that release (e.g. "closed in v1.2.3.4"). One other thing I would like is if it were possible to generate the complete release note (including the version for vNext, i.e. if I know vNext = 1.2.3.4, then have that verison number) so that I can generate the release note before tagging & releasing |
Closing this because the current code does this correctly. |
The release notes currently have the 'vNext' version at the top but all other tags are ordered by date starting with the oldest. I would expect that the oldest would be at the bottom.
The text was updated successfully, but these errors were encountered: