Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

Nuclei.Communication: Version the communication protocol #3

Closed
pvandervelde opened this issue Dec 3, 2013 · 2 comments
Closed

Nuclei.Communication: Version the communication protocol #3

pvandervelde opened this issue Dec 3, 2013 · 2 comments
Assignees
@pvandervelde
Labels
enhancement
Milestone
0.8.0

Comments

@pvandervelde
Copy link
Member

It looks like there are (at least) two levels of versioning that are needed:

  • Protocol level
  • API level

The protocol level defines:

  • The way data is translated on the wire. Currently we're using the .NET binary formatter which ties the two sides to the same version (signed version) of the Nuclei.Communication assembly. When versioning is put in place this needs to be changed (e.g. protocol buffers).
  • The available types of messages.
  • The available message processors and the way the message processing is done.
  • The handshake method. Part of the handshake method is the CommunicationSubject, however this doesn't provide enough information by itself to determine the protocol version (or to limit it, e.g. the handshake message is part of the protocol version and may change).
  • The discovery method.

The version for the the protocol level needs to be provided in the discovery so that both sides can indicate if they are capable of handling the given protocol version.

The API level defines:

  • Which command sets and notification sets exist AND what the version of those sets is (i.e. the exact type). The version of the API should be negotiable, i.e. both sides should be able to provide a list of known API versions they can use to communicate and then be able to negotiate the most suitable version to use. Note that this has implications for the user!
    • In case the application needs to support different versions of a command / notification set there will need to be a way to load the types for all versions. Depending on the implementation there may be .NET limitations.
    • Note that if the binary formatter isn't used for the bits => objects translation then the assembly version may not be all that important anymore for the API version.
@pvandervelde
Copy link
Member Author

The discovery needs to:

  • Be versioned separately so that it is independent from the protocol level
  • Provide all the available protocol versions that can be used to connect.

@ghost ghost assigned pvandervelde Jan 7, 2014
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Adding the Discovery and Protocol folders
281f806 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Moving elements to the discovery namespace
9a7fb1f 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Moving items into the discovery, protocol and interaction (for comman…
fe76b5a 
…ds and notifications) namespaces. Not completely done changing the actual namespaces yet.

references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Renaming namespaces
a6dddc7 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
More moving classes / interfaces to the new namespaces.
f97111d 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Fixing up compiler errors.
a24beed 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Adding the classes necessary for the discovery. New approach is to ha…
43f3847 
…ve a single channel (net.tcp://<MACHINE_NAME>:<PORT>/discovery) which will provide discovery capabilities.

references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Removing the discovery behavior from the TCP and named pipe protocol …
ae2c3d7 
…channel types.

references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Updating the IOC container.
ed745f5 
References #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Creating the discovery endpoint that responds to discovery requests
9680058 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Adding the versions of the discovery protocol.
d419a52 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Implemented the DiscoverySource which handles the querying of the rem…
9e362a1 
…ote discovery channels

references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Adding the files to the project.
bc008d3 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Moving the discovery information endpoint to the V1 namespace
78e7f53 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Updating the project file for the move of the discovery endpoint to t…
699dbf3 
…he V1 namespace

references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Defining the base interface for all WCF endpoints in the discovery na…
108f470 
…mespace.

references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Renaming the V1 discovery endpoint and adding a base interface for al…
125ed10 
…l versioned endpoints.

references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Completed the discovery bootstrap channel. The discovery channel creates
1626907 
- A bootstrap channel which can be queried for the URI's of the different versioned discovery channels.
- One or more versioned discovery channels which provide version specific information about the available protocols.

references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Adding XML comments to the IDiscoveryEndpoint interface
8263aed 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Adding the V1 discovery endpoints and the necessary translators.
88c3052 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Adding the WCF ServiceBehavior attributes to the discovery endpoints.
774ec75 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Adding protobuf.net to the communication project.
d1538b4 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Changing from the NetDataContractSerializer to ProtoBuf.NET
09aedb1 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Adding the ID of the endpoint to the stored channel information.
5785b76 
reference #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Adding the protocol versions
f46dc7c 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Fixing the protocol handshake class to make use of the new discovery …
cd5c059 
…namespace.

references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Moving the CommunicationLayerStarter to the main namespace
b3c824b 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Updating the V1 discovery elements to provide the endpoint ID.
3fdce49 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Unit test for the CommunicationLayer
b4ca818 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Renaming the CommunicationLayer and the CommunicationChannel to be th…
efa0d09 
…e ProtocolLayer and the ProtocolChannel respectively.

references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Updating the unit test project.
554175d 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Final set of unit tests
f667253 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Updating the command and notification registration delegates.
9b452ff 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Fixing compiler errors in the example application.
0bf6737 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Fixing up StyleCop errors.
c23acf1 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Fixing unit tests. Only 120 failures more to go ...
f32f89f 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Fixing more unit tests
e48f264 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Fixing more unit tests. Only 14 more to fix.
c563b88 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
More fixing of unit tests
811b25e 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Adding the DataContractResolver for the WCF connection so that it can…
7f48bdf 
… handle types that aren't declared in advance.

references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Fixing run time bugs. Lots of them ...
f53c1f6 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
More bug fixes
be5612b 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
And more bug fixes
a456879 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Final bug fixes
a21f551 
references #3
pvandervelde added a commit that referenced this issue Mar 24, 2014
@pvandervelde
Updating to 0.7.2.0
b21e92e 
references #3
@pvandervelde
Copy link
Member Author

Fixed as of 0.7.2.0

This was referenced Mar 24, 2014
Closed
Merged
@pvandervelde pvandervelde mentioned this issue Apr 6, 2014
Closed
pvandervelde added a commit that referenced this issue Jun 9, 2016
@pvandervelde
Moving elements to the discovery namespace
2afe2da 
references #3
pvandervelde added a commit that referenced this issue Jun 9, 2016
@pvandervelde
Moving the type loading methods into Nuclei
c6eb4aa 
references #3
pvandervelde added a commit that referenced this issue Jun 9, 2016
@pvandervelde
Making Id<TId, TInternalValue> a datacontract so that all derivatives…
745330d 
… can be data contracts if they so chose.

references #3
pvandervelde added a commit that referenced this issue Jun 9, 2016
@pvandervelde
Final set of unit tests
5923801 
references #3
pvandervelde added a commit that referenced this issue Jun 9, 2016
@pvandervelde
Fixing up StyleCop errors.
3ac5ee3 
references #3
pvandervelde added a commit that referenced this issue Jun 9, 2016
@pvandervelde
Fixing unit tests. Only 120 failures more to go ...
8bf5ad4 
references #3
pvandervelde added a commit that referenced this issue Jun 9, 2016
@pvandervelde
More fixing of unit tests
6f9090e 
references #3
pvandervelde added a commit that referenced this issue Jun 9, 2016
@pvandervelde
Updating to 0.7.2.0
0535c26 
references #3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pvandervelde pvandervelde

Labels
enhancement
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
1 participant
@pvandervelde