minor changes based on review

GitTools · Jan 19, 2021 · 6392cd9 · 6392cd9
1 parent 91148d8
commit 6392cd9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/GitVersionCore.Tests/Extensions/GitToolsTestingExtensions.cs b/src/GitVersionCore.Tests/Extensions/GitToolsTestingExtensions.cs
@@ -27,7 +27,7 @@ public static class GitToolsTestingExtensions
         public static ICommit CreateMockCommit()
         {
             var objectId = Substitute.For<IObjectId>();
-            objectId.Sha.Returns(Guid.NewGuid().ToString().Replace("-", "") + "00000000");
+            objectId.Sha.Returns(Guid.NewGuid().ToString("n") + "00000000");
 
             var commit = Substitute.For<ICommit>();
             commit.Id.Returns(objectId);

diff --git a/src/GitVersionCore/Git/ReferenceName.cs b/src/GitVersionCore/Git/ReferenceName.cs
@@ -14,7 +14,7 @@ public class ReferenceName : IEquatable<ReferenceName>, IComparable<ReferenceNam
 
         public ReferenceName(string canonical)
         {
-            Canonical = canonical;
+            Canonical = canonical ?? throw new ArgumentNullException(nameof(canonical));
             Friendly = Shorten();
             WithoutRemote = RemoveRemote();
         }

diff --git a/src/GitVersionCore/VersionCalculation/NextVersionCalculator.cs b/src/GitVersionCore/VersionCalculation/NextVersionCalculator.cs
@@ -29,7 +29,7 @@ public class NextVersionCalculator : INextVersionCalculator
 
         public SemanticVersion FindVersion()
         {
-            log.Info($"Running against branch: {context.CurrentBranch} ({(context.CurrentCommit != null ? context.CurrentCommit.ToString() : "-")})");
+            log.Info($"Running against branch: {context.CurrentBranch} ({context.CurrentCommit?.ToString() ?? "-"})");
             if (context.IsCurrentCommitTagged)
             {
                 log.Info($"Current commit is tagged with version {context.CurrentCommitTaggedVersion}, " +