-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitversion slows down dramatically with dotnet 4.7.1 #1361
Comments
I did some profiling and found the majority of the time the performance was spent in System.Diagnostics.StackTrace.ctor I'm not sure if it's worth doing the workaround mentioned in this thread or not. It depends when the fix from Microsoft is actually released. |
4.7.1. fix has been released 17 days ago. (KB4054856) |
It might be that #1374 helps in this regard, so I've merged that. If you're able to test that without a package being produced, please report back your findings. It would be great to have some BenchmarkDotNet tests for stuff like this. Preferably coupled with an online analysis server that can report back to Github when the performance deteriorates in a pull request. |
This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions. |
dllsdotnet470.txt
dllsdotnet471.txt
I've been chasing a strange performance issue with gitversion on some build servers. On most build servers gitversion takes about 1 minute to run and calculate the version number for a specific repo. On some new build servers it takes 10 minutes to do the same calculation on the same repo.
I reviewed the dlls loaded by gitversion on a slow machine and on a fast machine and was able to determine that the slow machines were running dotnet 4.7.1 and the fast machines had dotnet 4.7.0.
I installed dotnet 4.7.1, via chocolatey, onto a machine that was running quickly, taking about 1 minute to calculate the version number, and after rebooting that time has increased to about 10 minutes.
I'm running the command: gitversion from the root of my repo with no command line arguments in this test. I'm running the latest version of gitversion 3.6.4.
I've attached a list of the dlls loaded by gitversion and their version information with both dotnet4.7 and dotnet4.7.1 from the same machine.
The text was updated successfully, but these errors were encountered: