Improve performance - Filter list of all tags first by those parsable to a semantic version #1374
Conversation
- reduces `Getting version tags from branch` time for our repository from a 100 seconds to 2.5 seconds
|
I didn't see any existing performance tests, I've attempted a few times to write one using |
jkingry
changed the title
|
I haven't tried it, but I think BenchmarkDotNet looks good. I'd happily accept pull requests with a few benchmark tests in it, especially if it's hooked up with some online service that can report performance degradation as Github checks to pull requests. |
| }) | ||
| .SelectMany(c => tags.Where(t => c.Sha == t.Target.Sha).SelectMany(t => | ||
| var tags = new List<Tuple<Tag, SemanticVersion>>(); | ||
| foreach(var t in this.Repository.Tags) |
There was a problem hiding this comment.
Can you please insert a space between foreach and (?
| .Where(tag => !olderThan.HasValue || ((Commit) tag.PeeledTarget()).When() <= olderThan.Value) | ||
| .ToList(); | ||
| var allTags = new List<Tuple<Tag, SemanticVersion>>(); | ||
| foreach(var tag in context.Repository.Tags) |
There was a problem hiding this comment.
Can you please insert a space between foreach and (?
| IncludeReachableFrom = branch.Tip | ||
| }) | ||
| .SelectMany(c => tags.Where(t => c.Sha == t.Target.Sha).SelectMany(t => | ||
| var tags = new List<Tuple<Tag, SemanticVersion>>(); |
There was a problem hiding this comment.
Can you please extract this tag filter logic out to a descriptive method?
|
Seeing how this might fix #1361, I'll ignore what I've written in the review and just go ahead and merge. A followup PR that addresses the comments would be appreciated, though. Thanks for this! |
- as requested in GitTools#1374
As requested in pull request GitTools#1374
Getting version tags from branchtime for our repositoryfrom a 100 seconds to 2.5 seconds