Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Montonically increasing AssemblyFileVersion to satisfy the MSI #1366

Closed
ruhullahshah opened this issue Jan 26, 2018 · 2 comments
Closed

Montonically increasing AssemblyFileVersion to satisfy the MSI #1366

ruhullahshah opened this issue Jan 26, 2018 · 2 comments

Comments

@ruhullahshah
Copy link
Contributor

ruhullahshah commented Jan 26, 2018

We use GitFlow as our branching model and GitVersion 3 for versioning our Assemblies.

The versioning scheme in use is:
assembly-file-versioning-scheme: MajorMinorPatchTag.

GitVersion resets the Tag in beta releases at times and MSI requirement of strictly increasing FileVersion is violated.

Is there a solution existing for this issue? In case it is not, how about reading the Tag from environment if presented with a special syntax such as {$TAG}? We can then use the build number which is strictly increasing as the Tag

Issue #1157 has a similar requirement and so does Issue #648

@asbjornu
Copy link
Member

asbjornu commented Mar 9, 2018

Yes, I think this is a duplicate of #1157. We would love a PR solving this.

@ruhullahshah
Copy link
Contributor Author

Fixed with the #1385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants