NuGet version is gone, and there will be changes...

[GeertvanHorrik]

So GitVersion_NuGetVersion is gone but can be used by "LegacySemVerPadded". Apparently it will be changed for v3, so the idea is to introduce 2 new variables:

GitVersion_NuGetVersionV2 => synonym for LegacySemVerPadded
GitVersion_NuGetVersionV3 => synonym for ???

[JakeGinnivan]

Or we can just bring back NuGetVersion then when v3 drops we release v2 of GitVersion which switches NuGet from LegacySemVerPadded to SemVer?

[GeertvanHorrik]

To make it backwards compatible for me I added this code to the VariableProvider class:

            {"NuGetVersion", semanticVersion.ToString("lp", formatter)}, // synonym for LegacySemVerPadded
            {"Version", semanticVersion.ToString("l", formatter)}, // synonym for LegacySemVer

[JakeGinnivan]

Not sure bringing back Version is a good idea, it is too vague?

The other thing is should we pad the NuGet version by default, or should we have a NuGetPadded

[JakeGinnivan]

The padded is only needed if you have tags greater than 10. i.e

-beta11

[SimonCropp]

unfortunately we cannot determine when padding will be needed. so we always add it

[GeertvanHorrik]

It's just so I can go on vacation in 2 hours and I don't have to change a zillion of builds. I am not saying Version should go back in the official version, I have just built my own version for the sake of backwards compatibility.

I prefer padding all the time instead of switching when the moon and sun are on the same level but only in August.

[GeertvanHorrik]

And what does "0.2.0-unstable.10+10" mean? I can understand the 10 (that is the no of commits), but +10?

[SimonCropp]

given nugets history of dodgy versioning i suspect there will be more dodgy work arounds that will need to be applied to future nuget implementations of semver. so i am leaning towards naming them explicitly like @GeertvanHorrik NuGetVersionV2 and perhaps have a NuGetVersionLatest (or something similar) that targets the current release version of nuget

any drawbacks people can see? thoughts?

[JakeGinnivan]

@GeertvanHorrik how did you get that version number? For develop you should get 0.2.0.10-unstable

Lets take a beta. 0.2.0-beta.1+10 means the first beta (i.e no tags on the release branch) and 10 commits since the branch was taken. When you tag 0.2.0-beta.1 then the version will become 0.2.0-beta.2+11

[JakeGinnivan]

@SimonCropp I am happy with adding NuGetVersionV2 for now, then when v3 drops we figure it out then.

OR we just add NuGetVersion back now, and it is for the latest version of NuGet. So when NuGet v3 drops we go to v2 and have a breaking change

[JakeGinnivan]

@GeertvanHorrik basically the +metadata is a way to include additional metadata which doesn't change the semantic version. so 0.2.0-beta.1+10 == 0.2.0-beta.1+20 from a SemVer point of view

[GeertvanHorrik]

It's the result of SetBuildVersion call. When I debug with this url:

/url https://github.com/Orcomp/C5Intervals /b develop /output buildserver

Caused by a call to semanticVersion.ToString("f")

[JakeGinnivan]

Interesting, I think that is a bug possibly. But that is a separate discussion

[GeertvanHorrik]

@JakeGinnivan Created new issue for the possible bug: #202

[GeertvanHorrik]

I think we should do this:

• NuGetVersion <=== most current or latest NuGet version
• NuGetVersionV2
• NuGetVersionV3
• NuGetVersionV[next]

All agree?

[SimonCropp]

seams reasonable to me

[GeertvanHorrik]

Code is ready, but awaiting other pull request first.

[GeertvanHorrik]

In VariableProvider, at the bottom (before return variables):

        variables["Version"] = variables[LegacySemVer];
        variables["NuGetVersionV2"] = variables[LegacySemVerPadded];
        //variables["NuGetVersionV3"] = variables[LegacySemVerPadded]; // TODO: when v3 is released, determine what to use
        variables["NuGetVersion"] = variables["NuGetVersionV2"];

[andreasohlund]

I propose we lowercase it as well to avoide Beta/beta sorting issues?

Sent from my iPhone

On 08 Jul 2014, at 13:56, Geert van Horrik notifications@github.com wrote:

In VariableProvider, at the bottom (before return variables):

    variables["Version"] = variables[LegacySemVer];
    variables["NuGetVersionV2"] = variables[LegacySemVerPadded];
    //variables["NuGetVersionV3"] = variables[LegacySemVerPadded]; // TODO: when v3 is released, determine what to use
    variables["NuGetVersion"] = variables["NuGetVersionV2"];

—
Reply to this email directly or view it on GitHub.

[GeertvanHorrik]

Good idea. Only the NuGetVersion items?

[andreasohlund]

I'd say only nuget* since this only a nuget snag

Sent from my iPhone

On 08 Jul 2014, at 15:12, Geert van Horrik notifications@github.com wrote:

Good idea. Only the NuGetVersion items?

—
Reply to this email directly or view it on GitHub.

[GeertvanHorrik]

Once my other pull request is accepted, I will start a new one introducing this (don't want to mess around with too many branches with an upstream master).

[JakeGinnivan]

@GeertvanHorrik have merged your other PR

[GeertvanHorrik]

Already pushing new fixes. Was more work then I expected with all the unit tests...