New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] #2167 breaks building WPF applications #2181
Comments
@tpaxatb can you check this bug? |
Yeah I realized after the fact that netcore apps seem to build slightly different (i didn't have netcore 3 sdk until friday). I think maybe on the .net core that the UpdateAssemblyInfo should be turned off in the props file or something. I'll see about taking a look later if/when I get a chance, as our office is in the process of transforming to mandatory work at home due to government directives yesterday and today. |
Sure, take your time, any help is welcomed |
Looks like the PR I just opened should fix this: #2183 |
@bording, ok then, after we merge your PR we will validate it here |
closing, please reopen if still reproduces |
Describe the bug
The fixes made for #2167 seem to break building WPF applications because version attributes are added as duplicates.
Expected Behavior
Build should work and assembly info should not have duplicate attributes.
Actual Behavior
Assemblyinfo has duplicate version attributes.
Possible Fix
MarkupCompilePass1DependsOn
should not be modified to containUpdateAssemblyInfo
.Steps to Reproduce
Context
Tried to compile with the latest gitversiontask version.
Version 5.2.2 works fine. Only 5.2.3 shows this issue.
Your Environment
.NET Core SDK (reflecting any global.json):
Version: 3.1.101
Commit: b377529961
Runtime Environment:
OS Name: Windows
OS Version: 10.0.18363
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\3.1.101\
Host (useful for support):
Version: 3.1.2
Commit: 916b5cba26
The text was updated successfully, but these errors were encountered: