Don't enable UpdateAssemblyInfo for SDK-style projects #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this also fixes #2181. |
|
I haven't tested this but won't this disable the updating completely when using the sdk and having GenerateAssemblyInfo=false? I guess people might want to have the update from gitversiontask. How about some unittests that verify what happens? |
|
@batzen I would say that if you are using the SDK project system, you should be relying on the project system to provide those values. This is how GitVersionTask worked back in 4.x, and it's a bug that it stopped working that way. If someone has set GenerateAssemblyInfo to false, then I would think you would not want any assembly info generated at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2182 by adding a condition disable the target when
UsingMicrosoftNETSdkistrue.