Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number is not cached between projects in a solution #488

Closed
asbjornu opened this issue Jul 9, 2015 · 10 comments · Fixed by #594
Closed

Version number is not cached between projects in a solution #488

asbjornu opened this issue Jul 9, 2015 · 10 comments · Fixed by #594

Comments

@asbjornu
Copy link
Member

asbjornu commented Jul 9, 2015

As mentioned in #437, when GitVersionTask (version 3 beta 4) is installed in a solution, I get the following informational message when building every project in the solution.

INFO [07/08/15 14:57:03:21] Version not in cache. Calculating version.

It would speed the build up noticeably if the version number was successfully cached between projects.

@GeertvanHorrik
Copy link
Contributor

I think that it is possible that multiple instances of msbuild are running for the same sln. This means that caching must be done based on the sln name + last modification date of the .git folder. Not sure if we can do this in a short time period (still working very hard to create GitTools.Core to create a shared logic for all applications).

@asbjornu
Copy link
Member Author

asbjornu commented Jul 9, 2015

I see. Will it be possible to get this fixed within the timeframe of 3.0, or will this have to be postponed to a minor v3 increment some time in the future?

@JakeGinnivan
Copy link
Contributor

If someone submits a PR which fixes before I get a chance to finalise, it will be in. Otherwise it wont :P

@GeertvanHorrik
Copy link
Contributor

We are already trying to release 3.0 for months. Let's finish it and stop expanding its scope.

@GeertvanHorrik
Copy link
Contributor

@JakeGinnivan even with a PR, let's leave it out and plan for 3.1 (if anyone wants to take it). I prefer monthly releases over yearly releases anyway ;-)

@JakeGinnivan
Copy link
Contributor

Moving countries has really taken a toll on my spare time. Next week I will be releasing v3

@asbjornu
Copy link
Member Author

asbjornu commented Jul 9, 2015

@JakeGinnivan, @GeertvanHorrik sounds good.

@asbjornu
Copy link
Member Author

@JakeGinnivan I really hope #594 fixes the problem! Since it's already merged, is there any chance of a new minor release any time soon so I can verify the fix?

@JakeGinnivan
Copy link
Contributor

Yep, minor release hopefully this weekend. Want to get the bump via commit message stuff in for the 3.1 release :)

@asbjornu
Copy link
Member Author

@JakeGinnivan Great. I'll try to get the ConcurrentDictionary PR in before the next minor too. I'll hopefully have time to work on that monday. Does that sound OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants