Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check excluded branches for commits #684

Closed
orjan opened this issue Oct 11, 2015 · 0 comments
Closed

Don't check excluded branches for commits #684

orjan opened this issue Oct 11, 2015 · 0 comments

Comments

@orjan
Copy link
Contributor

orjan commented Oct 11, 2015

This performance issue occurs when your having a repository with many commits and many branches together with setting track-merge-target for a feature branch:
feature[/-]:
track-merge-target: true

When trying to inherit branch configuration we shouldn't evaluate excluded branches, since the operation for each branch takes a lot of time, if you look at the profiling below you'll see that we're evaluating 17 branches instead of 1:

image
orjan added a commit to orjan/GitVersion that referenced this issue Oct 11, 2015
@orjan
Make sure that we're not evaluating excluded branches.
0eb9eb5 
This commit removes the excluded branches before we're trying to find
branches containing the commit.

This will also exclude branches we it's not possible to find a
configuration.

Fixes GitTools#684
@orjan orjan mentioned this issue Oct 11, 2015
Merged
@orjan orjan closed this as completed in 33f8921 Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orjan @pascalberger