Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache merge base #1106

Closed
wants to merge 6 commits into from
Closed

Conversation

JakeGinnivan
Copy link
Contributor

Rebases and builds on #1100

DanielRose and others added 6 commits November 27, 2016 19:29
Pass on data, check that each branch is added only once.
Clear the caches for each new run of GitVersion.
…ository

This makes the cache non-static and hopefully easier to maintain in the long wrong
Repository = repository;
RepostioryMetadataProvider = new GitRepoMetadataProvider(repository);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix spelling to RepositoryMetadataProvider

@@ -54,7 +59,7 @@ public IEnumerable<Branch> GetBranchesContainingCommit([NotNull] Commit commit,
{
throw new ArgumentNullException("commit");
}

Logger.WriteDebug("Heh");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test logging?

@JakeGinnivan JakeGinnivan deleted the cache-merge-base branch December 4, 2016 01:20
@JakeGinnivan
Copy link
Contributor Author

Merged as part of #1100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants