Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1876, object reference not set to an instance of object #1887

Merged
merged 1 commit into from
Nov 5, 2019
Merged

GH-1876, object reference not set to an instance of object #1887

merged 1 commit into from
Nov 5, 2019

Conversation

arturcic
Copy link
Member

@arturcic arturcic commented Nov 5, 2019

Fixes GH-1876

asbjornu
asbjornu approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but is it possible to add at least one test that provokes the exception so we don't accidentally introduce this bug again in the future?

@arturcic
Copy link
Member Author

arturcic commented Nov 5, 2019

I'll add one test at least.

@arturcic
Copy link
Member Author

arturcic commented Nov 5, 2019

I added the unit test @asbjornu. I'll merge the fix.

@arturcic arturcic merged commit e09622c into GitTools:master Nov 5, 2019
jetersen
jetersen reviewed Nov 5, 2019
View reviewed changes
Copy link
Contributor

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@jetersen jetersen mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen left review comments

@asbjornu asbjornu asbjornu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitVersionTask 5.1.1: object reference not set to an instance of object.
3 participants
@arturcic @asbjornu @jetersen