Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem in sorting pre-release-tags #295

Merged
merged 1 commit into from
Nov 12, 2014

Conversation

dtabuenc
Copy link
Contributor

This fixes #294 which causes wrong ordering of pre-release tags.

@JakeGinnivan
Copy link
Contributor

@andreasohlund I can't merge after repo move :P But this is good to merge

@andreasohlund
Copy link
Contributor

Try now?

On Tue, Nov 11, 2014 at 3:07 PM, Jake Ginnivan notifications@github.com
wrote:

@andreasohlund https://github.com/andreasohlund I can't merge after
repo move :P But this is good to merge


Reply to this email directly or view it on GitHub
#295 (comment)
.

@gep13
Copy link
Member

gep13 commented Nov 11, 2014

@JakeGinnivan before you do that, can you check your emails? 👍

@gep13
Copy link
Member

gep13 commented Nov 12, 2014

@andreasohlund I don't seem to be able to assign labels, milestones, etc. Should I be able to? Wanted to start to take care of this.

@andreasohlund
Copy link
Contributor

My bad, should be ok now?

On Wed, Nov 12, 2014 at 4:50 PM, Gary Ewan Park notifications@github.com
wrote:

@andreasohlund https://github.com/andreasohlund I don't seem to be able
to assign labels, milestones, etc. Should I be able to? Wanted to start to
take care of this.


Reply to this email directly or view it on GitHub
#295 (comment)
.

@gep13
Copy link
Member

gep13 commented Nov 12, 2014

Yip, I can do it now, thanks!

@gep13 gep13 added this to the 1.3.4 milestone Nov 12, 2014
@gep13
Copy link
Member

gep13 commented Nov 12, 2014

@andreasohlund with the change in GitHub Organisation, were the VCS roots updated in TeamCity? I don't see the familiar feedback below indicating that the PR succeeded successfully?

@andreasohlund
Copy link
Contributor

Lemme, take a look!

On Wed, Nov 12, 2014 at 5:43 PM, Gary Ewan Park notifications@github.com
wrote:

@andreasohlund https://github.com/andreasohlund with the change in
GitHub Organisation, were the VCS roots updated in TeamCity? I don't see
the familiar feedback below indicating that the PR succeeded successfully?


Reply to this email directly or view it on GitHub
#295 (comment)
.

@andreasohlund
Copy link
Contributor

Fixed

gep13 added a commit that referenced this pull request Nov 12, 2014
Fix problem in sorting pre-release-tags
@gep13 gep13 merged commit 2d83b11 into GitTools:master Nov 12, 2014
@gep13
Copy link
Member

gep13 commented Nov 12, 2014

@dtabuenc thank you very much for your contribution here!

@gep13 gep13 removed this from the 1.3.4 milestone Nov 12, 2014
@gep13 gep13 added this to the 2.0.0 milestone Dec 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-release tag sorting is incorrect
5 participants