Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Wrong semver when making a PR from a hotfix branch to a main branch #3186

Closed
wants to merge 1 commit into from
Closed

[Bug] Wrong semver when making a PR from a hotfix branch to a main branch #3186

wants to merge 1 commit into from

Conversation

NightFox7
Copy link

@NightFox7 NightFox7 commented Sep 7, 2022 •
edited by asbjornu

Describe the bug
Running the gitversion calculation on a PR pull branch from Hotfix to Main result to a minor increment instead of a patch increment.
Here is some diagnostic logs :

 INFO [09/07/22 14:25:07:29] Found possible parent branches: master, origin/hotfix/0.4.1
    WARN [09/07/22 14:25:07:29] Failed to inherit Increment branch configuration, ended up with: master, origin/hotfix/0.4.1
Falling back to develop branch config
  INFO [09/07/22 14:25:07:29] End: Attempting to inherit branch configuration from parent branch (Took: 48.56ms)

I believe the fallback to develop causes the minor increment.

Expected Behavior

A Patch increment

Actual Behavior

A Minor increment

Related issues

Resolves #3187.

Possible Fix

Steps to Reproduce

See the test in the PR

Your Environment

  • Version Used: 5.10.3
  • Operating System and version (Windows 10, Ubuntu 22.04):

@NightFox7 NightFox7 mentioned this pull request Sep 7, 2022
Closed
@NightFox7 NightFox7 changed the title [Bug] Wrong semver calculation when making a PR from a hotfix branch to a main branch [Bug] Wrong semver when making a PR from a hotfix branch to a main branch https://github.com/GitTools/GitVersion/issues/3187 Sep 7, 2022
@NightFox7 NightFox7 changed the title [Bug] Wrong semver when making a PR from a hotfix branch to a main branch https://github.com/GitTools/GitVersion/issues/3187 [Bug] Wrong semver when making a PR from a hotfix branch to a main branch (issue #3187) Sep 7, 2022
@NightFox7 NightFox7 mentioned this pull request Sep 8, 2022
Open
@asbjornu asbjornu changed the title [Bug] Wrong semver when making a PR from a hotfix branch to a main branch (issue #3187) [Bug] Wrong semver when making a PR from a hotfix branch to a main branch Oct 25, 2022
@asbjornu
Copy link
Member

The accompanying issue #3187 was resolved in #3190. Do you agree that this PR thus can also be closed?

@NightFox7
Copy link
Author

Yes I will close it

@NightFox7 NightFox7 closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Wrong semver calculation when making a PR from a hotfix branch to main branch
2 participants
@NightFox7 @asbjornu