Use authentication in GitPreparer.GetRemoteReference
#468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nulltoken can you have a quick look over this one? |
| @@ -164,7 +164,7 @@ static void CreateFakeBranchPointingAtThePullRequestTip(Repository repo, Authent | |||
| repo.Checkout(fakeBranchName); | |||
| } | |||
|
|
|||
| static IEnumerable<DirectReference> GetRemoteTipsUsingUsernamePasswordCredentials(Repository repo, Remote remote, string username, string password) | |||
| public static IEnumerable<DirectReference> GetRemoteTipsUsingUsernamePasswordCredentials(Repository repo, Remote remote, string username, string password) | |||
There was a problem hiding this comment.
Why public rather than internal?
There was a problem hiding this comment.
Right, I overlooked that GitVersionCore internals are visible in GitVersionExe.
Sir! Done, Sir! |
|
Thanks for your feedback. I now added an overload of |
|
🆒 Looks 👍 to me. |
JakeGinnivan
added a commit
that referenced
this pull request
Jun 17, 2015
Use authentication in `GitPreparer.GetRemoteReference`
|
Thanks for your help @nulltoken! |
|
@JakeGinnivan As always, feel free to ping me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You already had a helper for this (
GitHelper.GetRemoteTipsUsingUsernamePasswordCredentials), but it was internal. I made it public.I saw somewhere else that you used
repository.Network.Remotes.Single(), which fails when there are multiple remotes, so I'm not sure if it's ok that I also used it.