Enable GitVersionTask to work with NuGet v3 #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimonCropp is this similar to the changes that had to be made in Fody? |
|
@gep13 yes, this is similar: https://github.com/Fody/Fody/blob/master/NuGet/Nuget.csproj#L50-L51 |
|
@gep13 yes. @onovotny this is very good work @JakeGinnivan this is good for a merge from my perspective |
JakeGinnivan
added a commit
that referenced
this pull request
Aug 12, 2015
Enable GitVersionTask to work with NuGet v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuGet v3 does not allow .props/.targets files directly in the
\builddirectory. They must be in a subdirectory.This PR puts the targets file in
\Build\portable-net+sl+win+wpa+wpand\lib\dotnetso it'll work with any NuGet v2 or v3 client. The relative paths in the .targets file has been adjusted to match the new location.Without this, the targets are never included in UWP or other project.json based projects (like modern PCL, etc).