Add support for relative logfile paths #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| writeActions.Add(x => WriteLogEntry(arguments, x)); | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| Console.WriteLine("Failed to configure logging: " + ex.Message); | ||
| Console.WriteLine("Failed to configure logging for '{0}': {1}", arguments.LogFilePath, ex.Message); |
There was a problem hiding this comment.
Logger.WriteWarning would be better than using Console.WriteLine is it's possible?
There was a problem hiding this comment.
I agree, I just didn't want to do anything about that in this (old) part of the code.
|
@asbjornu there're 2 failing log related tests, would you mind fixing them? |
…file's path is C:\GitVersion.log, i.e. to the root of a drive. Since that's a valid use case, `null` needs to be supported.
…broke a couple of tests
JakeGinnivan
added a commit
that referenced
this pull request
Oct 17, 2015
Add support for relative logfile paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the handling of
Arguments.LogFilePathsuch that it can be relative as well as absolute. It also improves what is logged to the console when the log file can't be created.