Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note to explain about fetchDepth restriction #736

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

seanarmstrong87
Copy link
Contributor

@seanarmstrong87 seanarmstrong87 commented Sep 16, 2022

Added a note in the giversion execute docs to explain that fetchDepth 0 is required


```yaml
- checkout: self
fetchDepth: 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have required to use fetchDepth of 0 in your comment, but fetchDepth: 1 in your example.

There is an existing note in the Github usage example, perhaps it can be copied from there?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with that, we need to add the note as well, would be nice to keep them in sync as they share the same interface but different implementations.

@seanarmstrong87
Copy link
Contributor Author

seanarmstrong87 commented Sep 17, 2022 via email

@arturcic
Copy link
Member

@seanarmstrong87 any updates on this one?

@seanarmstrong87
Copy link
Contributor Author

@arturcic Updated

@arturcic arturcic enabled auto-merge (rebase) October 10, 2022 14:59
@arturcic arturcic merged commit 14bc5e0 into GitTools:main Oct 10, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2022

Thank you @seanarmstrong87 for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants