Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed target attribute for external links #1363

Merged
merged 1 commit into from
Jun 9, 2016

Conversation

todvora
Copy link

@todvora todvora commented Jun 7, 2016

The attribute key/value for links that should be opened into a new window is target="_blank" but Gitbook generated _target="blank" (the underscore should be before attribute value, not name)

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-target

@SamyPesse
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants