Ignore empty articles, and be more flexible in parsing articles #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soreine
force-pushed
the
resilient-summary-article-parsing
branch
from
f780e2b
to
3b050c5
Compare
Soreine
force-pushed
the
resilient-summary-article-parsing
branch
from
3b050c5
to
e5a6ce7
Compare
SamyPesse
approved these changes
Mar 9, 2017
|
Whatever this issue fixes it does not appear to resolve GitbookIO/community#372 GitbookIO/community#411. Both issues are causing problems with asciidoc. Version 7.0.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once integrated in the Editor, this would
Fix Just a thought : Gitbook should have new and clean UI community#372 and fix New users are great ... dont forget the existing ones community#411
The reason is links in the parsed Slate.Document are surrounded by empty texts in Asciidoc, so considered as empty articles. And empty articles were not ignored.
Fix https://github.com/GitbookIO/editor/issues/571