Skip to content
This repository has been archived by the owner on Feb 21, 2019. It is now read-only.

Multi line highlighting #5

Merged
merged 12 commits into from
Oct 14, 2017
Merged

Multi line highlighting #5

merged 12 commits into from
Oct 14, 2017

Conversation

Soreine
Copy link
Contributor

@Soreine Soreine commented Jun 20, 2017 •
edited
Loading

Included in this PR:

  • Update dependencies (slate etc.)
  • Use slate-sugar 🍬
  • Support highlighting across several blocks

Currently, the highlighting works okay, by tokenizing the whole block's text:

  • ✅ The first pass is perfect.
  • ❌ Editing individual lines does not update the others
  • ❌ Moving the selection to another line will update the highlighting in the process, which breaks Slate's selection event handling.

@Soreine
Copy link
Contributor Author

Soreine commented Jun 20, 2017

ianstormtaylor/slate#893

This was referenced Oct 11, 2017
Closed
Merged
@Soreine
Copy link
Contributor Author

Soreine commented Oct 14, 2017 •
edited
Loading

Slate 0.26.0 fixed the remaining problems

screen shot 2017-10-14 at 10 25 10

@Soreine Soreine changed the title [WIP] Multi line highlighting Multi line highlighting Oct 14, 2017
@Soreine Soreine requested review from SamyPesse and removed request for SamyPesse October 14, 2017 08:32
@Soreine
Copy link
Contributor Author

Soreine commented Oct 14, 2017

@SamyPesse bless me

@Soreine Soreine merged commit 8b527f0 into master Oct 14, 2017
@Soreine Soreine deleted the multi-line-highlighting branch October 14, 2017 08:32
@Soreine Soreine mentioned this pull request Oct 14, 2017
Closed
@Soreine Soreine mentioned this pull request Nov 7, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Soreine