Skip to content

Commit

Permalink
services/wiki: Close() after error handling (go-gitea#27129)
Browse files Browse the repository at this point in the history
Refs: https://codeberg.org/forgejo/forgejo/pulls/1385

Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
(cherry picked from commit 589e7d3)

Co-authored-by: Lars Lehtonen <lars.lehtonen@gmail.com>
  • Loading branch information
2 people authored and GiteaBot committed Sep 19, 2023
1 parent b139234 commit 182e39d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions services/wiki/wiki_test.go
Expand Up @@ -249,8 +249,8 @@ func TestPrepareWikiFileName(t *testing.T) {
unittest.PrepareTestEnv(t)
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
gitRepo, err := git.OpenRepository(git.DefaultContext, repo.WikiPath())
defer gitRepo.Close()
assert.NoError(t, err)
defer gitRepo.Close()

tests := []struct {
name string
Expand Down Expand Up @@ -301,8 +301,8 @@ func TestPrepareWikiFileName_FirstPage(t *testing.T) {
assert.NoError(t, err)

gitRepo, err := git.OpenRepository(git.DefaultContext, tmpDir)
defer gitRepo.Close()
assert.NoError(t, err)
defer gitRepo.Close()

existence, newWikiPath, err := prepareGitPath(gitRepo, "Home")
assert.False(t, existence)
Expand Down

0 comments on commit 182e39d

Please sign in to comment.