Fix data-race bug when accessing task.LastRun (go-gitea#27584)

GiteaBot · Oct 11, 2023 · 228b81a · 228b81a
1 parent 7ec7c73
commit 228b81a
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/services/cron/cron.go b/services/cron/cron.go
@@ -107,12 +107,11 @@ func ListTasks() TaskTable {
 			prev = e.PreviousRun()
 		}
 
+		task.lock.Lock()
 		// If the manual run is after the cron run, use that instead.
 		if prev.Before(task.LastRun) {
 			prev = task.LastRun
 		}
-
-		task.lock.Lock()
 		tTable = append(tTable, &TaskTableRow{
 			Name:        task.Name,
 			Spec:        spec,