Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keeping disconnected nodes with Infomap #174

Merged
merged 1 commit into from May 28, 2021

Conversation

danieledler
Copy link
Contributor

A user of cdlib found that disconnected nodes are not included in the output when using Infomap. The reason is that cdlib only loops over the edges of a network when adding it to Infomap. (See this discussion)

Here we fixed this issue by adding the nodes. We also added a flag parameter that is passed to Infomap to enable all features to the user.

@GiulioRossetti
Copy link
Owner

Thanks for the fix, I'll merge it in the master ASAP.

Giulio

@GiulioRossetti GiulioRossetti merged commit 787a87b into GiulioRossetti:master May 28, 2021
@JohannHM
Copy link

Dear @GiulioRossetti Thanks for taking a look on the cdlib. It happen that I want to use the info map with weighted networks and disconnected nodes. But the output I got does not look like to be to the infomap weighted network version. Another thing is that disconnected nodes does not appear in any module at the end of the run.
I'll be very glad to read your comment if it's possible to fix it. I'll keep very in touch whether ewe had to re-install your package.
Regards to both @danieledler and @GiulioRossetti

@JohannHM
Copy link

JohannHM commented Jun 4, 2021

Hi @GiulioRossetti. I'm not sure whether disconnected nodes and weighted network version is already fixed. Would you please confirm if now this infomap features are already implemented? I ran a weighted network with disconnected nodes and nothing seems to change.
Thanks a lot for your huge work

@GiulioRossetti
Copy link
Owner

Hi, the pull request (already merged in master) contains the fix for both disconnected nodes and weighted networks. The update has not yet been ported in the pip package, I plan to to it within next week.

If you installed from the repository and still notice the issue let me know and I'll test it further.

@JohannHM
Copy link

Thank so much @GiulioRossetti. Eager to see your infomap implementation in pip, perhaps with an example of how using it with another flags different from the default inputs. Your release will be very important for the community. Thanks again for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants