Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifiable list of pre-defined attestor groups #9

Closed
divine-comedian opened this issue Apr 19, 2024 · 5 comments
Closed

Modifiable list of pre-defined attestor groups #9

divine-comedian opened this issue Apr 19, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request p2 A normal priority item

Comments

@divine-comedian
Copy link
Contributor

divine-comedian commented Apr 19, 2024

pre-defined attestor groups will be arbitrarily added by DeVouch at launch and expanded as more external teams wish to integrate with DeVouch.

An attestor group is defined by 3 fields:

  • schemaID
  • issuing authority (address that has to have issued the attestation)
  • name of attestor group

These attestor groups are used by #8 and other services to pass to the FE, showing vouches/flag details and counts.

This list should be structured in a way that external teams can make PRs requesting to update or add new attestor groups.

@divine-comedian divine-comedian added the p1 an item so critical to the release of the product that you would hold the release to include or fix label Apr 19, 2024
@aminlatifi
Copy link
Member

@divine-comedian You did create an organisation, are you happy with the script?

@divine-comedian
Copy link
Contributor Author

Yeah! I think it works great. Is there anything else left on this issue then?

@divine-comedian divine-comedian self-assigned this May 13, 2024
@divine-comedian
Copy link
Contributor Author

divine-comedian commented Jun 7, 2024

@aminlatifi

When I was playing around with this I noticed that if there is more than one pending PR for adding an organization when the first PR merges and second PR after that will have a merge conflict because the add-organisation.js file has been changed as a result of the first PR being merged.

Is there a way to prevent this from happening? what about using the .gitignore file or something similar?

I also noticed in the folder system we keep production and staging migrations in the same folder, do you recommend separating them?

@divine-comedian divine-comedian added p2 A normal priority item enhancement New feature or request and removed p1 an item so critical to the release of the product that you would hold the release to include or fix labels Jun 7, 2024
@aminlatifi
Copy link
Member

@aminlatifi

When I was playing around with this I noticed that if there is more than one pending PR for adding an organization when the first PR merges and second PR after that will have a merge conflict because the add-organisation.js file has been changed as a result of the first PR being merged.

Is there a way to prevent this from happening? what about using the .gitignore file or something similar?

I also noticed in the folder system we keep production and staging migrations in the same folder, do you recommend separating them?

Done by #72

@maryjaf
Copy link
Collaborator

maryjaf commented Jun 11, 2024

Should I do some test about this? @divine-comedian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p2 A normal priority item
Projects
Status: Done
Development

No branches or pull requests

3 participants