Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch the speed up issue with metamask #1133

Closed
GriffGreen opened this issue Feb 10, 2020 · 2 comments
Closed

Watch the speed up issue with metamask #1133

GriffGreen opened this issue Feb 10, 2020 · 2 comments
Assignees
Labels
feature request All issues that require new implementations

Comments

@GriffGreen
Copy link
Member

No description provided.

@GriffGreen
Copy link
Member Author

complicated... speeding up a tx replaces the old tx and feathers doesnt realize that the tx that was replaced... but the simulation script does know!!! So it removes the old messed up tx and replaces it...!

SO the Simulation script, if it was rewritten to only simulate the most recent blocks then it can update this.

We can apply this later eventually

@arbreton arbreton added the feature request All issues that require new implementations label Mar 12, 2020
@GriffGreen
Copy link
Member Author

This is what people will do... They will donate and then be like!! WOW thats expensive! I'll make it Cheaper
Donating and lowering the cost

That makes this tx: https://etherscan.io/tx/0x244cb1301e75061fe0fef930440ede995fc71c0198c35f6c36205127fb815461

And then they will be like... oh man... this is taking forever, and i need to do other things with my address... I guess I'll pay more
speed up the tx

Then a new tx is made, replacing the old one:
https://etherscan.io/tx/0x4b897aa1f0aad8c9d1b2a8dcd61984c44b7e7dea115751fb94ab656d88c6f4b6

The first one is in a limbo where it was sent to the network and then replaced and eventually forgotten. The DApp doesn't know that this tx will never go through so it just sits there in pending forever.

The Second one actually donates the money but our dapp has no clue it happened... until the simulation script or something else tells it there was a donation. The DApp thinks this is just a new donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request All issues that require new implementations
Projects
None yet
Development

No branches or pull requests

3 participants